Terrax Lighting system

Hey Terrax!


Welcome back, I am doing amazing things with my game thanks to your lighting system. I just wanted to report two bugs (one big, one small) that I have found.


1) (Small Deal) (posted earlier in case you haven't seen it) The player's fire effect gets messed up and looks like some weird force field effect when you try update the players fire effect then change the tint of the screen in the same event. So, the work around is, you have to tint the screen first before you update the players fire effect so the fire effect works properly. Not too big of a deal.


2) (BIG Deal), lets say you enter a dungeon and use a torch to light up a few lanterns. If you load a previous save on the same map(the one before you light the lanterns), the lights will be on even though you never turned them on (and the lanterns will be in the off position).


Anyways once I update my game I will give you a copy of it to check out yourself ;0). I think you will love what I have done with my custom time (Not omg hunters) and weather system + your script. ;0)

Yes, there are a number of issues with the way i save variables at this moment. I'm going to do a complete overhaul of that part of the system, it should remove problems and also fix a few compatilibilty problems with other plugins.

@Terrax


Sounds great.


I also want to add one more issue, just in case you are unaware of it.


1) When light sources move or teleport (happens to players characters, etc) the light source does not teleport with them. 


Good luck and I look forward to the updated release.


Thanks for everything.

Terrax i've asked before but obviously it's going to be difficult to find my post I left for you undernieth the hundreds of others.


But the last version I have downloaded has issues regarding lights on events dragging poorly on moving events, switches to have lights on and off do not seem to work either.


Thanks mate.

Do you make use of tile-lights or region-lights on big maps? Tile and region lights cycle with loops over the complete map multiple times a second and can cause problems on bigger maps or maps with lots of regions.


The same could happen with large maps containing a very high number of events.


Try to create a smaller map and see if the problem persists.

I make use of lights with terrain tags and maps are on most occasions small size such as 30x30 and sometimes something like 50x50.


Lights on those maps work perfectly along with some of the very few region tile lights i use.


Made some tests but find that vehicle lights track moving events poorly and it looks like they are having trouble catching up- prior to the last update they were moving smoothly. Since the update light commands on the players vehicle has gone also: I am not sure if your last update had this function removed.

Ill have a look when im done with the save-game issues. (going over the complete script with a fine tooth-comb to change all the variables takes a bit of time)

God speed. I hope you succeed and make the most perfect script out there.


Although it's frustrating finding bugs- that's just the process to refining them.

Skurge, i think this issue is related to compatiblity problems with another addon, can you do a test by putting the lighting addon at the bottom of the addon list (or disabling others) and see if the problem persists. If that fixes the problem, you can test what addon causes the problem by turning then on one by one.


Ill take a look at the addon that causes the problem and see if i can fix it.

I will do so and check if anything changes for the better.


In the meantime just to be sure I am doing this correctly- can you establish to me what needs to be done for the following:


Torch lights that move with events and given on command to have them turn on and off?


Torch lights to work with vehicles and if possible is there a function I can use to have the lights turn on when entering them?


I believe this is the note tag for the lights Flashlight 8 12 #888888 1 2


but they are only pointing upward instead of the direction in which the event is facing.


Sorry to be a pain: it's just I find the help window confusing.

Serveral options are available


'Fire 200 #FFCC00 1' in the note tag of an event will give the NPC a torch, but it will be off at the start, you will have to turn it on with


'Light on 1' and off again with 'Light off 1'


Another option is to just give it a normal torch with  'Fire 200 #FFCC00' and to turn it on and off with the 'kill switch'. The killswitch can be configured


in the options of the plugin (you have to scroll down a bit). The default setting is 'No'. If you chance this to 'D' then whenever you throw selfswitch 'D' on


an event with lights, the lights will go off.


Yes, but it requires a little script. There is an example of a boat working that way in the demo that is included.




You have the tag right, the fact that it isn't moving is another indication of a conflict with another plugin.


 Yes, the helpfile can (and will) be done much better soon, although i probably should do it in a help-text-file because there isn't much room in the help screen.

Hi terrax, I'm happy to see you here. Look, the problem with the shake screen remained. If I enlarge the coverage area in the plugin and use the shake screen, on the right is all ok, but left during the shake see the end of the cover color.


Please, try to do the same thing. it seems that it is not centered. if you enlarge X, you enlarge the screen to the right and not also to the left.


Thank you very much!

Turned off all plugins to begin with except for the lighting plugin off course: Result seems to be the same, I can't quite figure out what's wrong with it.


Looking at the demo now to see what might else be the problem with my own.


EDIT: Came across something that's got me stumped- according to your plugin events that have torch lights show in the direction they are facing are required to face down first up. The problem with this I have is that some of the events I that use this light command at first do not have a graphic and therefore cannot have a direction to begin with. I have tried to have the first movement command set them to face down first up but this does not work.


Secondly I had copied the event of the girl that uses the torch light movement to my own project- inside a small room the light is constantly facing right and the light moves to the spot where the event is going to go instantly before the event itself moves over with no flowing animation-dispite being the exact same thing copied over with no conflicting plugins active. I can't think of anything else I am doing wrong.

New version (1.3.2) now available


http://mvplugins.com/plugin/Terrax/Terrax%20Lighting%20System


or


https://github.com/Terraxz/TerraxLighting


Added :


Nothing.


Changed:


Complete overhaul of the way variables are handled and saved. Saving and loading should be much more consistent now and some compatibilty problems with other plugins should be gone as well. This took a lot of work and changed code, if you run into new errors or stuff isn't working like before, please report it so i can look if i missed something.


Skurge: I would love to debug it for you, anyway i can get a single map or more of your game that has the problem?


DarkSearinox92 : I will take another look when i'm done fixing Skurge's problem.


 

Updated the project with your new updated plugin:


Put the JS on the top of the list and recieved this error:


TypeError


Cannot read property 'toLowerCase' of underfined

OOOH YEAH NEW VERSION!!!! <3


Thank you very much Terrax, please keep me informed.

Looks like this will be the only have the problem looked at. I'll try to create one.

Can you press F8 when you get that error and copy/paste the window that pops up?

There is a problem. If i set Player Radius 0, the player still have light around... :/

I can confirm this also.


Here is my console bug report screenshot, and I figured you would like to look at my js plugins file aswell.



View attachment plugins.js