MV - Olivia Horror Effects memory leak

Prescott · 2024-05-23T21:44:51+0900

UPDATE: @Arthran has found the leak and patched it. Kudos! I think I have found a memory leak issue with the Horror Effects plugin from Olivia. Clearing an effect from the player does remove the effect visually, but it seems like every time a new effect is added it just drives up the memory usage more. I have an item in my game that, when equipped, causes a Glitch effect to occur every 10-20 seconds on the player. It clears after 30 frames. This was causing the game to crash within about 30 minutes. I tried testing it out without a parallel process event, just one event that would switch between giving you the glitch effect and removing it, and it seems to be the case that it indeed does continually increase memory usage by a few MB each time it is applied. I'm guessing the reason nobody has found this until now is simply because they're not trying to use it in a parallel process event xD Most people will probably not use it so many times that it would matter much. If anyone could take a look at the plugin for me, or perhaps offer a backup solution, it'd be sweet. I'd let Olivia know about it but I'm not quite sure how to contact them, as comments are disabled on their itch.io page for the plugin and it doesn't look like they have an account here from what I can see. It's fully possible that this could be an issue on my end as well, so if anyone else has the plugin and would test it so I can rule it out if it is indeed functioning correctly for you, it'd be awesome. I have heard of some people getting memory leaks before swapping to a newer version of nw.js so it's totally possible I just need to do that as well. It's just that I didn't start having this issue until I got to the point in my game where this item is acquired and testing it gave concrete results.

● ARCHIVED · READ-ONLY

Started by Prescott May 23, 2024, 12:44 PM 45 posts Page 3 of 3 View original ↗

ShadowDragon

#41 Jun 11, 2024, 08:18 AM Source

aren't olivia plugins obfuscated? as I have one unobfuscated.
not sure if I can use it, but it's amazing what it can do though to fiddle around :D

I think all of olivia's plugin is obfuscated, even if you can alter the code for your
own use, but I think chaucer is right about deleting the shader/pixi filter effect
as it has a lof of code obfuscated which I believe is the pixi filter code.
Prescott

#42 Jun 11, 2024, 10:21 AM Source

Eliaquim said:
Well, I know you didn't asked me but, I have one for MV that will be free in a couple of days. The MZ version will continue to be paid though.
Hakuen Studio Horror Filter for RPG Maker MZ by Hakuen Studio
But an horror filter, is just a mix of filters. You can easily replicate, I believe, my plugin or Olivia plugin with a free plugin that adds PIXI Filter.
If I'm right, Tsukimi already did a plugin for that:
Pixi Filter Controller - fancy screen effects by pixi (MZ version released!)
Wow, this is awesome! Great work :) I would actually pay for it if I'm able to get a refund for Olivia's. I'd rather send the money your way if I can.

ATT_Turan said:
Personally, I think all this is just a built-in feature.

The growing anxiety of never knowing when the game is about to crash and leave your progress unsaved - that's horror!
Funny enough, the Glitch feature is used in my game as a corruption effect. So the game falling apart at the seams is pretty on-brand xD Definitely not great for a player experience though lol. Although, imagining a game that slowly corrupts itself until taking up too much space in RAM before crashing is pretty funny.

Arthran said:
Yeah, sure. I'm stuck in bed with a pretty nasty fever right now, but I can probably muster up the energy within the next couple days.

I'd have to take a good look at some things to get a precise estimate, but I reckon it would run somewhere between like $50-$100. But as Eliaquim said, there are already a couple alternatives out there.

And honestly, if anyone is super set on using Olivia's plugin, I'd be willing to make a patch for it for free, if someone is willing to buy me the plugin. I've already taken a gander at the MZ version, and I was able to locate the issue, so I presume that the MV version wouldn't take me more than two minutes to fix.
Aww man, I hope you get feeling better soon! Honestly the only reason why I would like it to be reported at all, especially now knowing that good alternatives exist, is that it is still being sold by a very popular plugin developer. It affects all users who have paid for it and are using it in their games!
Arthran

#43 Jun 12, 2024, 09:19 AM Source

Thanks to @TheAM-Dol 's generous sponsorship, I was able to create a patch that fixes the memory leaks in Olivia's Horror Effects plugin. Just add the patch to your project through the plugin manager, and make sure that it is below the Horror Effects plugin. Make sure to remove it if Olivia ever releases an official fix.

For anyone curious about the issue, there was a very large leak present, specifically when using the "glitch" effect, and specifically when the target is a character sprite or a battler. To be clear, you don't need to continuously remove and restart the effect for the leak to happen--just turning it on and letting it run causes it to continuously eat memory. In my testing, after turning on the glitch effect for all 4 party members, and letting the game sit idle for 2 minutes, my game's memory usage climbed from about 180 MB to 1.1 GB.

There was also a memory leak that happened any time any horror effect is removed from any target. However, the amount is so small that it would be hard to notice.

As far as I can tell, the patch fixes it all. However, if I missed anything, don't hesitate to let me know.
ShadowDragon

#44 Jun 12, 2024, 09:31 AM Source

never knew that one that one as I couldn't tell inside the code.
nice catch on fixing it @Arthran and for making it :)

maybe an own thread as well to find it easier?
Prescott

#45 Jun 13, 2024, 11:39 AM Source

Arthran said:
Thanks to @TheAM-Dol 's generous sponsorship, I was able to create a patch that fixes the memory leaks in Olivia's Horror Effects plugin. Just add the patch to your project through the plugin manager, and make sure that it is below the Horror Effects plugin. Make sure to remove it if Olivia ever releases an official fix.

For anyone curious about the issue, there was a very large leak present, specifically when using the "glitch" effect, and specifically when the target is a character sprite or a battler. To be clear, you don't need to continuously remove and restart the effect for the leak to happen--just turning it on and letting it run causes it to continuously eat memory. In my testing, after turning on the glitch effect for all 4 party members, and letting the game sit idle for 2 minutes, my game's memory usage climbed from about 180 MB to 1.1 GB.

There was also a memory leak that happened any time any horror effect is removed from any target. However, the amount is so small that it would be hard to notice.

As far as I can tell, the patch fixes it all. However, if I missed anything, don't hesitate to let me know.
What a legend! I was running into the issue with the effect being added and staying running at first, and when I tested it I saw it happening even when removing the effect, so it's great this fixes both of those cases. Thank you so much for your work!