MV - Olivia Horror Effects memory leak

Prescott · 2024-05-23T21:44:51+0900

UPDATE: @Arthran has found the leak and patched it. Kudos! I think I have found a memory leak issue with the Horror Effects plugin from Olivia. Clearing an effect from the player does remove the effect visually, but it seems like every time a new effect is added it just drives up the memory usage more. I have an item in my game that, when equipped, causes a Glitch effect to occur every 10-20 seconds on the player. It clears after 30 frames. This was causing the game to crash within about 30 minutes. I tried testing it out without a parallel process event, just one event that would switch between giving you the glitch effect and removing it, and it seems to be the case that it indeed does continually increase memory usage by a few MB each time it is applied. I'm guessing the reason nobody has found this until now is simply because they're not trying to use it in a parallel process event xD Most people will probably not use it so many times that it would matter much. If anyone could take a look at the plugin for me, or perhaps offer a backup solution, it'd be sweet. I'd let Olivia know about it but I'm not quite sure how to contact them, as comments are disabled on their itch.io page for the plugin and it doesn't look like they have an account here from what I can see. It's fully possible that this could be an issue on my end as well, so if anyone else has the plugin and would test it so I can rule it out if it is indeed functioning correctly for you, it'd be awesome. I have heard of some people getting memory leaks before swapping to a newer version of nw.js so it's totally possible I just need to do that as well. It's just that I didn't start having this issue until I got to the point in my game where this item is acquired and testing it gave concrete results.

● ARCHIVED · READ-ONLY

Started by Prescott May 23, 2024, 12:44 PM 45 posts Page 2 of 3 View original ↗

RCXGaming

#21 Jun 6, 2024, 09:00 PM Source

Arthran said:
The issue might actually be worse than this. I just tested the MZ version of this plugin, and it also seems to have the memory leak. However, there was no need to continually apply and remove the glitch effect. Just turning on the glitch effect once, and letting it stay on, caused my RAM usage to continually increase. I didn't time it super accurately, but as far as I could tell, it seemed like the memory usage ticked up at exactly the same rate that the glitch effect occurred.

So I just want to corroborate that the memory leak happens to me too. I ran two tests - one with the Horror Effects plugin enabled and one with it off, both for 15 minutes.

I ran back and forth around in an empty map (no parallels, only 4 events).

With Olivia's Horror Effects constantly being reapplied to an event via a Show Choice command, the memory usage often climbed significantly. Strangely though, it never got so high it would crash, even for my potato laptop, capping at 900-ish MB. But it would lag horrifically, with the FPS being dropped to 28-ish and the game stuttering as the player moved.

With the Horror Effects plugin disabled, the FPS drop doesn't happen at any point.

As much as I like the Horror Effects, I'd much rather not deal with this.
Prescott

#22 Jun 7, 2024, 02:55 AM Source

I have sent an email to the Visustella help address to report the issue as it seems even more users are running into it now.
ATT_Turan

#23 Jun 7, 2024, 03:15 AM Source

Good luck. It's not a VisuStella product, so I predict it's unlikely you'll get a response that way.
Prescott

#24 Jun 7, 2024, 08:28 AM Source

ATT_Turan said:
Good luck. It's not a VisuStella product, so I predict it's unlikely you'll get a response that way.
The MZ version is: https://visustellamz.itch.io/horror-effects
ATT_Turan

#25 Jun 7, 2024, 11:29 AM Source

Okay, but who in this thread has talked about that plugin? Or done any of the memory tests on it?
Prescott

#26 Jun 7, 2024, 02:23 PM Source

Arthran said:
The issue might actually be worse than this. I just tested the MZ version of this plugin, and it also seems to have the memory leak. However, there was no need to continually apply and remove the glitch effect. Just turning on the glitch effect once, and letting it stay on, caused my RAM usage to continually increase. I didn't time it super accurately, but as far as I could tell, it seemed like the memory usage ticked up at exactly the same rate that the glitch effect occurred.

ATT_Turan said:
Okay, but who in this thread has talked about that plugin? Or done any of the memory tests on it?
:)
Prescott

#27 Jun 10, 2024, 12:03 PM Source

Quick update, it appears that Olivia doesn't have any contact information anywhere. I'd highly advise against buying any of their plugins on Itch.io because you won't get any support for it and there won't be any easy way of fixing it. I'm not familiar with how Itch.io works with sales and such, but if you have to manually input it then Olivia is still watching over their Itch.io account and collecting funds from it despite being completely disconnected from the community. I have to say I'm very disappointed with this outcome. I'm going to attempt getting a refund on the plugin.

I got a response from Visustella and they said they couldn't do anything because it's not their plugin, it's Olivia's, and Olivia has no contact information. I responded telling them that they hosted the MZ version, which evidently has the same issue, on their Itch.io and on yanfly.moe and asked if they could please either attempt fixing it if possible or at least add a disclaimer that it may have memory issues. We'll see what happens I guess.
ATT_Turan

#28 Jun 10, 2024, 03:55 PM Source

I suspect they're going to tell you that's not the correct method for submitting a bug with a VisuStella plugin.
Prescott

#29 Jun 10, 2024, 09:40 PM Source

ATT_Turan said:
I suspect they're going to tell you that's not the correct method for submitting a bug with a VisuStella plugin.
You were correct lol. They told me to use this form instead: http://www.yanfly.moe/wiki/Troubleshooting_Plugins_RPG_Maker_MZ

That being said, I don't actually own the MZ version of the plugin, nor do I want to pay money for it. @Arthran would you be willing to file a report?
chaucer

#30 Jun 11, 2024, 01:01 AM Source
TheAM-Dol said:
It just feels like there is a certain group of plugin devs who are all affiliated with each other in one way or another who really seem to hate their customers and think every one of their customers is a dirty rotten, code stealing pirate.
:kaoswt: I swear I'm not a pirate D: I only stea- ahem... borrow... code from chat-gpt and stack overflow Q__Q

werzaque said:
My biggest peeve is that a certain team requires you to upload a project to drive to demonstrate an issue with a plugin. In other words they want (nay, require) you to do the issue isolation for them.

lol I do this too Q__Q at least, when I dont fully understand what the actual issue is, or I cannot replicate it, or if it's too much setting up plugins to specific values, which takes like an hour to get done D; then I'll ask for a demo project lol. :c So I am guilty of this too D:

Also on topic of the actual thread, this looks like it's probably a simple fix, if the code wasn't obfuscated, or if it wasn't against the terms of use to edit it.. I would definitely help out as i believe it takes only adding an extra line of code.

More than likely it seems as if the code is probably not recycling shaders, and instead of generating new shaders every time, on top of that, the old shaders are most likely not being disposed of properly ><; if that is indeed the case, all you need to do is find where the shader is removed, and find the name of the shader, then run seomthing along the lines of...
JavaScript:
oldShader.destroy( true );
which would remove reference to the shader, allowing it to be later cleared by the garbage collector ^^

At least, this is if I am right lol..

Even if the code is obfuscated, you can relatively easily find the shader...

as all you really need to do is search where "filters = ..." or "filter.push", or "filter.unshift" is ran... from there that is the point at which the shader is added.. and from there you have the shaders name... then just gotta find where it's removed...

But... lol yeah...
TheAM-Dol

#31 Jun 11, 2024, 01:40 AM Source

Out of curiosity, what would the estimate be in order to commission... Effectively this exact same plugin, but with open terms and code?
@chaucer or @Arthran
Eliaquim

#32 Jun 11, 2024, 03:00 AM Source

TheAM-Dol said:
Out of curiosity, what would the estimate be in order to commission... Effectively this exact same plugin, but with open terms and code?
@chaucer or @Arthran
Well, I know you didn't asked me but, I have one for MV that will be free in a couple of days. The MZ version will continue to be paid though.
Hakuen Studio Horror Filter for RPG Maker MZ by Hakuen Studio
But an horror filter, is just a mix of filters. You can easily replicate, I believe, my plugin or Olivia plugin with a free plugin that adds PIXI Filter.
If I'm right, Tsukimi already did a plugin for that:
Pixi Filter Controller - fancy screen effects by pixi (MZ version released!)
ATT_Turan

#33 Jun 11, 2024, 03:02 AM Source

Eliaquim said:
Well, I know you didn't asked me but, I have one for MV that will be free in a couple of days.
Good to know!

Eliaquim said:
If I'm right, Tsukimi already did a plugin for that:
I was just about to post that link :biggrin:

I believe the only thing missing from that plugin that's in the horror effects is the glitch. It has the scanlines and noise, and the ability to target characters/events/the screen.
StandardEnemy

#34 Jun 11, 2024, 03:07 AM Source

I love the Pixi Filter plugin, its so dang useful!
ATT_Turan

#35 Jun 11, 2024, 03:08 AM Source

Personally, I think all this is just a built-in feature.

The growing anxiety of never knowing when the game is about to crash and leave your progress unsaved - that's horror!
Eliaquim

#36 Jun 11, 2024, 03:09 AM Source

ATT_Turan said:
I believe the only thing missing from that plugin that's in the horror effects is the glitch. It has the scanlines and noise, and the ability to target characters/events/the screen.
- The MZ version has the glitch filter, at least it shows on the screenshots of the plugin command. Don't know about MV though. Or if the author just forgot to tell that exists is the glitch filter on the documentation.
ATT_Turan

#37 Jun 11, 2024, 03:13 AM Source

Eliaquim said:
- The MZ version has the glitch filter, at least it shows on the screenshots of the plugin command. Don't know about MV though. Or if the author just forgot to tell that exists is the glitch filter on the documentation.
I don't know either way, I only looked at the forum post for the MV version since that's what the OP of this thread uses.
TheAM-Dol

#38 Jun 11, 2024, 04:23 AM Source

@Eliaquim sorry bud, I know you're a good programmer too, but they were the first 2 wizards that came to mind that I have worked with. :LZSsmile:
I could have also tagged @Mac15001900

But hopefully your version gets the job done.
(to be honest, a little disappointed... For.... Reasons...)
Arthran

#39 Jun 11, 2024, 06:23 AM Source

Prescott said:
@Arthran would you be willing to file a report?
Yeah, sure. I'm stuck in bed with a pretty nasty fever right now, but I can probably muster up the energy within the next couple days.

TheAM-Dol said:
Out of curiosity, what would the estimate be in order to commission... Effectively this exact same plugin, but with open terms and code?
I'd have to take a good look at some things to get a precise estimate, but I reckon it would run somewhere between like $50-$100. But as Eliaquim said, there are already a couple alternatives out there.

And honestly, if anyone is super set on using Olivia's plugin, I'd be willing to make a patch for it for free, if someone is willing to buy me the plugin. I've already taken a gander at the MZ version, and I was able to locate the issue, so I presume that the MV version wouldn't take me more than two minutes to fix.
TheAM-Dol

#40 Jun 11, 2024, 06:25 AM Source

Arthran said:
if someone is willing to buy me the plugin.
Consider it done. Can you send me a PM with Paypal info?

Edit:
Uh... After you recover from the illness of course :kaoswt2: