MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 49 of 64 View original ↗

WickBRSTM

#961 Jul 26, 2022, 09:21 AM Source

Fortunastreet said:
Actually, you were right, it can happen in some weird edge case; I will be working on a fix soon.

You can have both if they are in the correct order. Remember offsets require an initial 'x' or a 'y'.
Thank you for your help! One more thing I wanted to ask, for some reason it doesn't seem to like it when I offset the light by decimal values even though it seems that in the readme they can be read just fine. Any idea what the deal is with that?
Fortunastreet

#962 Jul 26, 2022, 11:45 AM Source
Sorry everyone, I did go on holiday and completely forgot about this thread.

WickBRSTM said:
If I were to do something like, say, this...
View attachment 233734
The first command works fine, but the second does not.

I created a pull request with the fix.

ephesus said:
Is there a chance that we will ever be able to use images as light masks/images as lights? Can I officially request it??

All said, thanks for this plugin and all the hard work that's been put into it!

Since this plugin was never made with light images in mind, so it would be quite an amount of work to do so.

Skurge said:
Currently i'm just using this plugin for light effects as my game's setting is based in a low photosynthesis city. I currently have weather conditions made on common events activated by switches and was wondering if I am able to somehow tie in random weather to times of the day with this plugin?

Is this possible?

You can link variables to the hours of the day and a switch to daytime/nightime. I don't know if it is enough?

Hamoody said:
For some reason when I do a transfer event with no fade-out, a small window appears in the top right of the screen for a quick second before disappearing. I tried disabling all plugins except for community lightning and same result :rswt

That's weird. There is only one new window who comes with this plugin, and it is the window who show the time of the day (the one activated with the Daynight show/Daynight showseconds) plugin commands. You didn't happen to activate it by mistake?

WickBRSTM said:
Thank you for your help! One more thing I wanted to ask, for some reason it doesn't seem to like it when I offset the light by decimal values even though it seems that in the readme they can be read just fine. Any idea what the deal is with that?

Here is a functioning notetag example, say me if it helps:
Code:
Fire 30 #CC0000 X0.35 Y-0.35
Note that the 0.35 float correspond to a number of squares, and that a square are 48x48 pixels. So it means roughly 17 pixels.
TheAM-Dol

#963 Jul 28, 2022, 07:09 AM Source

Hello there,
Is there any hope of getting the light mask extended to...well...effectively fit the entire size of the map, rather than the camera? I posted my problem here.
Fortunastreet

#964 Jul 30, 2022, 06:19 PM Source

TheAM-Dol said:
Hello there,
Is there any hope of getting the light mask extended to...well...effectively fit the entire size of the map, rather than the camera? I posted my problem here.

Wow, you are putting the plugin in a corner.
Did you try with a light mask size matching your zoom?
TheAM-Dol

#965 Aug 1, 2022, 07:57 AM Source

Fortunastreet said:
Did you try with a light mask size matching your zoom?
How can I do that? Is resizing a feature new to the Community Lighting version of Terrax Lighting system?
Fortunastreet

#966 Aug 1, 2022, 10:28 AM Source

TheAM-Dol said:
How can I do that? Is resizing a feature new to the Community Lighting version of Terrax Lighting system?

See the parameters who determine the light mask size (normally, it matches the resolution of the game). Note that you will probably have to shift the mask north-east so it is centered.
TheAM-Dol

#967 Aug 1, 2022, 12:45 PM Source

Fortunastreet said:
See the parameters who determine the light mask size (normally, it matches the resolution of the game). Note that you will probably have to shift the mask north-east so it is centered.
Thanks for the reply.
I actually found a different solution...more like a compromise with my problem...but, either way it works. I appreciate your help, though.
FrigidGaze

#968 Aug 1, 2022, 04:37 PM Source

Heya!

Thank you for the awesome plugin and all the hard work put in, guys, it's most appreciated!

I just wanted to chime in and say that I was also experiencing some odd issues regarding a small, empty window briefly appearing at the top right of the screen before vanishing, though in my case it's whenever I close a menu. As I understand it, it has something to do with the Day/Night time display, correct? Which as far as I'm aware I've fully disabled within the settings!

As a quick fix on my end since I wouldn't be using the time feature, is there a way to potentially comment out the window displaying parts in the plugin code itself to omit it, or would it be tied into too many other parts for that to be viable?
Torarrios

#969 Aug 1, 2022, 10:24 PM Source

I'm trying to get the offset to work on the Use Flashlight event. I've followed the Readme format and it's not working. I basically copied the Use Flashlight from the demo and made some small changes, the X and Y I exaggerated so I can test results and it still centers on the characters feet, which would be great if I weren't using a taller character model. My program is MV and I grabbed whatever version is linked on the first page of this thread. Is it because it's being activated from an item? I only need it a half a space up or so.

Thank you for your time

Update: it works when it's an event in the world, but not when it's a common event it seems
Fortunastreet

#970 Aug 2, 2022, 11:32 PM Source
FrigidGaze said:
Heya!

Thank you for the awesome plugin and all the hard work put in, guys, it's most appreciated!

I just wanted to chime in and say that I was also experiencing some odd issues regarding a small, empty window briefly appearing at the top right of the screen before vanishing, though in my case it's whenever I close a menu. As I understand it, it has something to do with the Day/Night time display, correct? Which as far as I'm aware I've fully disabled within the settings!

As a quick fix on my end since I wouldn't be using the time feature, is there a way to potentially comment out the window displaying parts in the plugin code itself to omit it, or would it be tied into too many other parts for that to be viable?

I think I know where it is coming from; in
JavaScript:
Window_TimeOfDay.prototype.initialize = function (x, y, width, height) { width = 150; height = 65; Window_Base.prototype.initialize.call(this, Graphics.boxWidth - width, 0, width, height); this.setBackgroundType(0); };
For some reason, the window isn't hidden when it is initialized, only on the first update, so that's may be the cause.
Try to code the following code to this method:
JavaScript:
this.visible = $gameVariables._clShowTimeWindow;
If it solves the issue, I will add it on the github.

Torarrios said:
I'm trying to get the offset to work on the Use Flashlight event. I've followed the Readme format and it's not working. I basically copied the Use Flashlight from the demo and made some small changes, the X and Y I exaggerated so I can test results and it still centers on the characters feet, which would be great if I weren't using a taller character model. My program is MV and I grabbed whatever version is linked on the first page of this thread. Is it because it's being activated from an item? I only need it a half a space up or so.

Thank you for your time

Update: it works when it's an event in the world, but not when it's a common event it seems

I see you have multiple flashlight plugin command in a row, you are aware that they will override each other?
FrigidGaze

#971 Aug 3, 2022, 12:17 PM Source
Fortunastreet said:
I think I know where it is coming from; in

JavaScript:
Window_TimeOfDay.prototype.initialize = function (x, y, width, height) { width = 150; height = 65; Window_Base.prototype.initialize.call(this, Graphics.boxWidth - width, 0, width, height); this.setBackgroundType(0); };

For some reason, the window isn't hidden when it is initialized, only on the first update, so that's may be the cause.
Try to code the following code to this method:

JavaScript:
this.visible = $gameVariables._clShowTimeWindow;

If it solves the issue, I will add it on the github.
Ahh, apologies--I should have specified I'm using the MZ branch of the plugin, as I don't believe I can find that particular bit of code in the MZ one and assume it's written slightly differently?
LyraVultur

#972 Aug 3, 2022, 12:38 PM Source

FrigidGaze said:
Ahh, apologies--I should have specified I'm using the MZ branch of the plugin, as I don't believe I can find that particular bit of code in the MZ one and assume it's written slightly differently?
Line 3519 in the MZ version, at least on my end
FrigidGaze

#973 Aug 3, 2022, 01:48 PM Source

LyraVultur said:
Line 3519 in the MZ version, at least on my end
Thank you!

I added the line in as suggested, and it looks like that fixed the issue with the window popping up in the corner for my initial tests.
Fortunastreet

#974 Aug 3, 2022, 03:10 PM Source

TheAM-Dol said:
Thanks for the reply.
I actually found a different solution...more like a compromise with my problem...but, either way it works. I appreciate your help, though.

After fully reading your thread, I added some lines to the plugin documentation since it just pointed out to another functionality of TerraxLighting that was unknown until now.

FrigidGaze said:
Thank you!

I added the line in as suggested, and it looks like that fixed the issue with the window popping up in the corner for my initial tests.

Nice, I added the change in my pull request, too.
Rapidox

#975 Aug 6, 2022, 11:52 PM Source

Hello,

First of all thank you for this wonderful plugins.

Sorry in advance for the writing, I'm French and i'm not super good in English and I use my knowledge and google trad to write.

I use on RMMV.
I just have a problem with the lighting of the player because it is just non-existent.

I have a cave area with torches on the wall and the light works great on it but I also have dark areas with no light where the player is supposed to move around using a torch in their hand and I can't activate the light of the torch held by the player

I tried a lot of plugin commands like:
<cl: Flashlight l24 w72 #ff0000 on sdir0> or
<cl: Flashlight l24 w72 #ff0000 on asdf> (As listed in the sample order)
I also tried without quotes and without cl:
but nothing works.

Thanks again and good luck for the rest
Torarrios

#976 Aug 7, 2022, 02:57 AM Source

Fortunastreet said:
I see you have multiple flashlight plugin command in a row, you are aware that they will override each other?
I was not aware of this... I thought they would stack to make a different color gradient.
Rapidox

#977 Aug 7, 2022, 09:31 AM Source

Rapidox said:
Hello,

First of all thank you for this wonderful plugins.

Sorry in advance for the writing, I'm French and i'm not super good in English and I use my knowledge and google trad to write.

I use on RMMV.
I just have a problem with the lighting of the player because it is just non-existent.

I have a cave area with torches on the wall and the light works great on it but I also have dark areas with no light where the player is supposed to move around using a torch in their hand and I can't activate the light of the torch held by the player

I tried a lot of plugin commands like:
<cl: Flashlight l24 w72 #ff0000 on sdir0> or
<cl: Flashlight l24 w72 #ff0000 on asdf> (As listed in the sample order)
I also tried without quotes and without cl:
but nothing works.

Thanks again and good luck for the rest
Ok sorry, i've found what i'm not doing right and now it work.

Sorry for the time lost and thanks again for the plugins.
ephesus

#978 Aug 7, 2022, 04:25 PM Source

Is an 8 direction flashlight possible? implementation?
Torarrios

#979 Aug 8, 2022, 10:49 PM Source

Fortunastreet said:
I see you have multiple flashlight plugin command in a row, you are aware that they will override each other?
I have removed the extra instances of flashlight however the original problem remains of the flashlight not being able to be offset vertically
Fortunastreet

#980 Aug 10, 2022, 04:04 PM Source

Right now I'm busy at work and I have my own game to work on, but I have more time:

ephesus said:
Is an 8 direction flashlight possible? implementation?

Terraxlighting was made with 4-direction movement in mind, but implementing 8-direction is theoretically possible from what I saw on the code.

Torarrios said:
I have removed the extra instances of flashlight however the original problem remains of the flashlight not being able to be offset vertically

I will be looking for it and the same time.

mobiusclimber said:
So the Community Lighting plugin lets you set the tint screen for battles, but I can't see how to add lights. Basically, the battles are dark and I'd like to put a light on the enemy or add a spotlight or something, anything, so it's not just "dusky" looking. Anyone know how to do this?

I will also see for adding lights to battle, as it has been requested multiple times.