MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 41 of 64 View original ↗

Zaha

#801 Dec 28, 2021, 03:03 PM Source

Sorry for the newbie question - my game is using a day/night system that transfers players to a set map depending on if it's day or night (time is prosessed by events, not a set clock), so I only want the effects from this to work in the evening and night maps. What you would be the best settings for this please?

***edit: For MZ
Fortunastreet

#802 Dec 30, 2021, 08:32 AM Source

Zaha said:
Sorry for the newbie question - my game is using a day/night system that transfers players to a set map depending on if it's day or night (time is prosessed by events, not a set clock), so I only want the effects from this to work in the evening and night maps. What you would be the best settings for this please?

***edit: For MZ

Just deactivate the plugin with plugin command for the day map, and re-enable it when leaving it.
Zaha

#803 Dec 30, 2021, 08:56 AM Source

Alexandre said:
Just deactivate the plugin with plugin command for the day map, and re-enable it when leaving it.
Thanks for the reply. I tried to do this by adding a note to the map, but it didn't work (very likley due to me not doing something right). I'll add try adding the plugin command to my transfer event as you've suggested and see how that works.
Fortunastreet

#804 Dec 30, 2021, 10:38 AM Source

Zaha said:
Thanks for the reply. I tried to do this by adding a note to the map, but it didn't work (very likley due to me not doing something right). I'll add try adding the plugin command to my transfer event as you've suggested and see how that works.

What I usually do, on any map I know there will be light changes, is placing a parallel event who activate/deactivate the plugin (and change the light or the player radius if needed) and then delete itself.

What fade in teleportation, the screen is still black when the change occurs, so the player can't notice the abrupt change of lighting.
Zaha

#805 Dec 30, 2021, 11:06 AM Source

Alexandre said:
What I usually do, on any map I know there will be light changes, is placing a parallel event who activate/deactivate the plugin (and change the light or the player radius if needed) and then delete itself.

What fade in teleportation, the screen is still black when the change occurs, so the player can't notice the abrupt change of lighting.
Thanks for the further tips. I've got it working by adding it to the common event I use forst shifting time along after an event, but I'll try yours out so it's not as abrupt.

Sorry to pester, but I have another newbie question I'm not able to work out. I'm trying to get the lights going as events (following the demo), but the 'CL' notes I've copied over don't seem to be working. I've made sure 'cl' is actived in the plugin, but still no help - any idea what I may be doing wrong?
Fortunastreet

#806 Dec 30, 2021, 11:12 AM Source

Zaha said:
Thanks for the further tips. I've got it working by adding it to the common event I use forst shifting time along after an event, but I'll try yours out so it's not as abrupt.

Sorry to pester, but I have another newbie question I'm not able to work out. I'm trying to get the lights going as events (following the demo), but the 'CL' notes I've copied over don't seem to be working. I've made sure 'cl' is actived in the plugin, but still no help - any idea what I may be doing wrong?

What did you placed inside the Note Tag Key parameter?
Zaha

#807 Dec 30, 2021, 11:17 AM Source

Alexandre said:
What did you placed inside the Note Tag Key parameter?

<cl: fire 80 #e87407 B5 D9>
Fortunastreet

#808 Dec 30, 2021, 11:19 AM Source

Plugin parameter should I have precised.
Zaha

#809 Dec 30, 2021, 11:25 AM Source

Alexandre said:
Plugin parameter should I have precised.
Sorry, my fault - this is the first plugin I've started to use, so I'm not familure with the terms at all. Do you mean the 'cl'?
Fortunastreet

#810 Dec 30, 2021, 11:41 AM Source

Alexandre said:
Possibilities:
-You turned off the 'Lighting effect' option. So no lights are present.
-The current tint is '#FFFFFF' (no darkness at all)
-The script has been desactived via plugin command.
-You actived the plugin parameter to require a light event to show the light effects but on the map you test there is no light events.
Zaha

#811 Dec 30, 2021, 11:57 AM Source

I can't seem to see any of those being the issue, but I'll speand more time testing as I must be missing something. Thank you again for taking the time to help - have a good NY :)
Fortunastreet

#812 Dec 30, 2021, 06:09 PM Source

Zaha said:
I can't seem to see any of those being the issue, but I'll speand more time testing as I must be missing something. Thank you again for taking the time to help - have a good NY :)
Also, if you have daynight active on your map, it will force the tint to be whatever your color is for the current (game) time.
Synrec

#813 Dec 30, 2021, 11:52 PM Source

Thank you for this plugin system. Will definitely help for my project.
Zaha

#814 Dec 31, 2021, 06:34 AM Source

Alexandre said:
Also, if you have daynight active on your map, it will force the tint to be whatever your color is for the current (game) time.
Thanks for the clarifcation - I noticed this while playing around with the settings trying to figure out what's wrong :)
Izy

#815 Jan 3, 2022, 09:51 PM Source

Hello there! Thank you for this amazing plugin to all the Contributors and to iVillain for making this effort! Really appreciate having this plugin, it's amazing <3

I can't see if this has been raised before, but a little bug to note in a very specific circumstance (the plugin works perfectly for me otherwise):

- What? 48x96ish px box outlined with the System Window appears in the top right-hand corner in game on Transfer Player briefly. I haven't managed to be quick enough to catch a screenshot!
- When? Whenever using "Transfer Player" with Fade set to None in a map. I've tried this a few times in different games/maps/sequences and in the Demo with no other plugins, by adding a Transfer in the start event. Occurs on both parallax and standard maps.
- Temp fix on user side: Setting the "Transfer Player" Fade to Black or White will mean the box doesn't appear any more (although those fades may impact your game in minor ways)

Thanks very much and Happy New Year! <3

EDIT 04/01: I can't get this to reoccur on the demo project today, so this could well be user error or another plugin conflict, I'll report back!
Fortunastreet

#816 Jan 4, 2022, 02:14 PM Source

Izy said:
Hello there! Thank you for this amazing plugin to all the Contributors and to iVillain for making this effort! Really appreciate having this plugin, it's amazing <3

I can't see if this has been raised before, but a little bug to note in a very specific circumstance (the plugin works perfectly for me otherwise):

- What? 48x96ish px box outlined with the System Window appears in the top right-hand corner in game on Transfer Player briefly. I haven't managed to be quick enough to catch a screenshot!
- When? Whenever using "Transfer Player" with Fade set to None in a map. I've tried this a few times in different games/maps/sequences and in the Demo with no other plugins, by adding a Transfer in the start event. Occurs on both parallax and standard maps.
- Temp fix on user side: Setting the "Transfer Player" Fade to Black or White will mean the box doesn't appear any more (although those fades may impact your game in minor ways)

Thanks very much and Happy New Year! <3

Could you post a video with the bug (if you are on windows, windows key + G will open the xbox bar)?
I sometimes use transfer with no transition, but I never encountered such bug.
Izy

#817 Jan 4, 2022, 08:55 PM Source

Alexandre said:
Could you post a video with the bug (if you are on windows, windows key + G will open the xbox bar)?
I sometimes use transfer with no transition, but I never encountered such bug.
Hi Alexandre!

I tried several times this evening to replicate it to make a recording and (typically) I can't now get it to reoccur on the demo project! If I don't encounter it over the next day or so we'll put this down to user error or a different plugin conflict. If I find the cause I'll report back! Thank you :)
Aerosys

#818 Jan 8, 2022, 09:39 AM Source

I created a PR for this project to resolve an incompatibility with my plugin (see my signature), please review it and give feedback.

Update setupEvents and check "isErased" by mkampermann · Pull Request #56 · ImaginaryVillain/community_lights
ImaginaryVillain

#819 Jan 8, 2022, 10:54 AM Source

Aerosys said:
I created a PR for this project to resolve an incompatibility with my plugin (see my signature), please review it and give feedback.

Update setupEvents and check "isErased" by mkampermann · Pull Request #56 · ImaginaryVillain/community_lights
Doesn't look like a disruptive or even a major change. I just approved it so people can test it. If it causes a problem I'll revert it before the next release, but honestly I can't imagine it will.
Skurge

#820 Jan 10, 2022, 06:09 PM Source

Been looking to find a lighting plugin to port to MZ, origionally I was using Khas lighting and it's fantastic, but so far incompatible for my project, does this plugin have a lighting option bound to terrain tags?

This is so I can mark preset colours to already map maps with terrain numbers set.