MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 32 of 64 View original ↗

DarkSearinox92

#621 May 14, 2021, 06:41 AM Source

Aesica said:
I'm confused. I don't really see what "idea" you're talking about. As for the lag, I can't reproduce it so it might be related to your hardware specs. Lighting plugins in general add overhead to RM projects.

@Aesica No, no no, you've not read the right point. I've written the point 1, told you about a problem that when you start the game, the time game variable is setted to 0 but all switches are not updated at the start and you must force it with the command. The point 2 was about the lag and we talked about enough.

You replied me here, at point 1:

MV - Community Lighting MV & MZ
Saying this:

Aesica said:
I see what's happening now and it was very easy to reproduce. That's easy enough to fix, so I'll add it in next time I do plugin stuff. Thanks for catching it!

But maybe you forgotten it.

As the idea, i written about the Region block, six posts ago. Just up here.

DarkSearinox92 said:
I was thinking ... why not also insert a plugin setting where you can put a default RegionBlock, where you can select idregion and tint, so that the plugin applies the option directly, without having to run it in the game every time that you lunch it, for test for example? Obviously, if you were to change the color or the region during the game, this data would replace the previous ones configured in the plugin.

However, I find it stupid to change this data on that specific configured id region. The Region Block usually only uses it on top of walls and in those areas where the light "shouldn't come".

Maybe we can call this Region Block a Special Fixed region block?

But every time you start the game, maybe even during the tests, you have to launch the command by hand. Maybe a default value would suit us and be useful. I think it's easy to add.

What do you think about it?
SiRPiGgSaLoT

#622 May 14, 2021, 11:58 PM Source

Hey all. Just curious, and this may have been mentioned elsewhere, but there is a random light event type that appears on the uppermost left tile on my maps. Is there a setting I'm missing? Should I just add space to the map to remove this? Tried to attach an image showing my issue but it's too large? (3mb)
Aesica

#623 May 15, 2021, 07:48 AM Source

DarkSearinox92 said:
@Aesica No, no no, you've not read the right point. I've written the point 1, told you about a problem that when you start the game, the time game variable is setted to 0 but all switches are not updated at the start and you must force it with the command. The point 2 was about the lag and we talked about enough.

You replied me here, at point 1:

MV - Community Lighting MV & MZ
Saying this:

But maybe you forgotten it.

As the idea, i written about the Region block, six posts ago. Just up here.
I don't really think it's that bad to just include things like region block configuration in a new game setup event. I've always just set mine up in the same event that fires up the prologue cutscene. Adding a plugin param setting just for that seems unnecessary.

As for the time bug, yeah I overlooked it and it's sort of linked to another bug with time I eventually want to fix, but it's a low priority at the moment.

SiRPiGgSaLoT said:
Hey all. Just curious, and this may have been mentioned elsewhere, but there is a random light event type that appears on the uppermost left tile on my maps. Is there a setting I'm missing? Should I just add space to the map to remove this? Tried to attach an image showing my issue but it's too large? (3mb)
Is the upper left corner event the event you use to activate the tinting for a given map? If so, you can just set it to an empty light: <cl: light 0 #000>

RyanYe said:
This plugin is far better than terrax one, thank you!
But i want a plugin command that can change the flashlight for "event" in the middle of game , just like characters.

is it possible?
Try the page-based note tags (put the note tag in the first comment on an event page). Then, to change the flashlight for that event, just change its page via switch, self switch, variable, etc.
EmmieFinch

#624 May 16, 2021, 11:03 PM Source

Im having severe performance drops, i was wondering if anyone knew how to fix or at least mitigate that issue
Aesica

#625 May 17, 2021, 02:10 AM Source

EmmieFinch said:
Im having severe performance drops, i was wondering if anyone knew how to fix or at least mitigate that issue
Lighting plugins in general cause reduce performance because they're doing a lot. If you're testing on an older computer, and especially if you have a lot of events active, you're going to notice some performance hits. Other than that, you'll have to provide some examples of what exactly is causing your performance hits:

"It lags when I have _______ on the screen"
"Framerate drops when ___ number of lights are visible at once"
etc
DarkSearinox92

#626 May 17, 2021, 09:01 AM Source

EmmieFinch said:
Im having severe performance drops, i was wondering if anyone knew how to fix or at least mitigate that issue

First: upload your nwjs.
Second: I see that Playtest is more slow that the deployed project.

Third: Follow advises that Aesica told you

Aesica said:
I don't really think it's that bad to just include things like region block configuration in a new game setup event. I've always just set mine up in the same event that fires up the prologue cutscene. Adding a plugin param setting just for that seems unnecessary.

As for the time bug, yeah I overlooked it and it's sort of linked to another bug with time I eventually want to fix, but it's a low priority at the moment.

1) I thought region block configuration because when you test the game you always have to run an event for have a "real" perspective of how the map will be. That's why. I know that in a new game is simple to add the command in the starting event. It's only boring in the playtest. That's why. Maybe a plugin configuration only for a playtest will be a qualitative improvement for the palytest.

2) About the bug that the time will not be synchronized with the variable 0 when you start the game, i understand. I will wait a fix. This is always for playtest, of course...
RyanYe

#627 May 18, 2021, 04:05 PM Source

Aesica said:
Try the page-based note tags (put the note tag in the first comment on an event page). Then, to change the flashlight for that event, just change its page via switch, self switch, variable, etc.
The event tag is now:
<cl: Flashlight 16 28 #222222 0 4>
and it will sure work

but when i change it to event's comment as follows:
<cl: Flashlight 16 28 #222222 0 4>
cl: Flashlight 16 28 #222222 0 4
//cl: Flashlight 16 28 #222222 0 4
Flashlight 16 28 #222222
Flashlight 16 28 #222222 0 4
None of above works

any idea?
Aesica

#628 May 19, 2021, 07:36 PM Source

RyanYe said:
The event tag is now:
<cl: Flashlight 16 28 #222222 0 4>
and it will sure work

but when i change it to event's comment as follows:
<cl: Flashlight 16 28 #222222 0 4>
cl: Flashlight 16 28 #222222 0 4
//cl: Flashlight 16 28 #222222 0 4
Flashlight 16 28 #222222
Flashlight 16 28 #222222 0 4
None of above works

any idea?
It has to be the first comment in the event, at the very top.
RyanYe

#629 May 20, 2021, 01:56 AM Source

Aesica said:
It has to be the first comment in the event, at the very top.
yes it is!
have you tried that?
if yours is a success, can you post screenshot?

I mean the "flashlight" , not others
Aesica

#630 May 20, 2021, 05:59 AM Source

RyanYe said:
yes it is!
have you tried that?
if yours is a success, can you post screenshot?

I mean the "flashlight" , not others

Note that it can sometimes take a few moments to show up when switching pages if you don't have an empty light tag <cl: light 0 #000> in the main note box.

Edit: Also check your version. The latest is 4.2
DarkSearinox92

#631 May 20, 2021, 09:38 AM Source

Aesica said:
View attachment 189767
Note that it can sometimes take a few moments to show up when switching pages if you don't have an empty light tag <cl: light 0 #000> in the main note box.

Edit: Also check your version. The latest is 4.2

OT: Aesica what is the program that you're using for test? o.o i see a different icon, idem that icon in the upper right of the screen... (i know that is obviously nwjs, but it seems different lol), have you changed only the icon? And that button is an addon for something?
RyanYe

#632 May 20, 2021, 01:50 PM Source

Aesica said:
The latest is 4.2
mine is 2.6 , where to find 4.2?
thank you!!
Fortunastreet

#633 May 20, 2021, 02:05 PM Source

RyanYe said:
mine is 2.6 , where to find 4.2?
thank you!!

It is on Aesica's fork of the project: https://github.com/Aesica/community_lights
Aesica

#634 May 20, 2021, 08:04 PM Source

I (finally...god I forgot again ffs) sent the pull request to the main repo, so hopefully it's up to date now, too.

DarkSearinox92 said:
OT: Aesica what is the program that you're using for test? o.o i see a different icon, idem that icon in the upper right of the screen... (i know that is obviously nwjs, but it seems different lol), have you changed only the icon? And that button is an addon for something?

It's just a basic project in MZ, which does use a different icon and nwjs version
ImaginaryVillain

#635 May 20, 2021, 10:36 PM Source

GitHub really is a dumb service. It had me download their software because it couldn't deal with the merge online. I dealt with their apparent multi-month error with their software, got that working... And do you know what merge option the software has? Replace the file with the old one... You know the thing that GitHub should just have standard on it's website. :LZSgrump:

Anyway, it's been updated.
RyanYe

#636 May 21, 2021, 02:15 AM Source

Aesica said:
I (finally...god I forgot again ffs) sent the pull request to the main repo, so hopefully it's up to date now, too.

It's just a basic project in MZ, which does use a different icon and nwjs version

I use MV, i am wondering that if it is possible to do such feature with 4.2 version?

ImaginaryVillain said:
Anyway, it's been updated.

hi Villain!
Why not use dropbox?
I think it's faaaaaaaaaaaaaaaaar better than github imo
ImaginaryVillain

#637 May 21, 2021, 02:56 AM Source

Honestly, the others seem to like GitHub and I barely even look at it at the moment due to being involved in too many other projects. So I just leave it and occasionally have to deal with GitHub's little... "issues". It's not really difficult, I'm just making fun of it for being poorly designed. :LZSwink:

As for the other, the way this plugin works is by creating a massive black bitmap over the screen, then drilling holes into it. So unfortunately there would need to be some serious changes to make such a thing work. I'll leave it to the others to decide they want to do that.

You could however just place a black circle over the spot and set it's opacity to 30% or something. You wouldn't even need the plugin at that point. It's even possible to use RM's picture command to do so, and the move command to adjust the height/width on a loop to make it "flicker".
Aesica

#638 May 21, 2021, 02:59 AM Source

RyanYe said:
Why not use dropbox?
I think it's faaaaaaaaaaaaaaaaar better than github imo
Version control, mostly. I don't think dropbox has that, so if, for example, I make a huge up that totally breaks the plugin but don't realize it until it's too late, either someone has a previous working version or we're in trouble.

As for the dark tower thing, your best bet is to tint the map as dark as you want the darkest spots, then put a few reaaaally big lights in the "bright as day" area
DarkSearinox92

#639 May 21, 2021, 12:16 PM Source

ImaginaryVillain said:
GitHub really is a dumb service. It had me download their software because it couldn't deal with the merge online. I dealt with their apparent multi-month error with their software, got that working... And do you know what merge option the software has? Replace the file with the old one... You know the thing that GitHub should just have standard on it's website. :LZSgrump:

Anyway, it's been updated.

It's very strange. The same PIXI is all on github... and a lot of other softwares.
ImaginaryVillain

#640 May 22, 2021, 06:08 AM Source

I think I'll remove the UMC files from the project and start it's own repository. I really doubt many people use it anyway, and as it's focus is very different than the main plugin, no need to confuse people.

@DarkSearinox92
Honestly, it's really not bad, I'm just pointing out how dumb it was to need me to install software and deal with some awkward software issues just to use a simple file replace. It would have been no problem to just include that as an option on the site.