MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 31 of 64 View original ↗

LyraVultur

#601 May 9, 2021, 10:26 AM Source

Try changing "Light event required" in the plugin parameters to true, this will make every map without and light of some kind full bright.

Monkeynugget said:
Quick Question : I finally ported over the latest build into my main project going from V3.2 to V4.2 seems i missed a few versions but i noticed now that unlike previously

Any map that doesnt have this map notetag is now pure darkness, which is weird

ANyone know what would be driving that
View attachment 188787
Passingbyposts

#602 May 9, 2021, 10:39 AM Source

LyraVultur said:
Try changing "Light event required" in the plugin parameters to true, this will make every map without and light of some kind full bright.
View attachment 188788
yep i tried that but i have an issue wherein any map with a light event but not map tag is pitch black

really weird not sure what changed
LyraVultur

#603 May 9, 2021, 10:43 AM Source

Monkeynugget said:
yep i tried that but i have an issue wherein any map with a light event but not map tag is pitch black

really weird not sure what changed
Ah, it's always been like that for me, but i haven't been using Community Lighting for long. You can use the map notetag <Daynight hour h m> maybe? As the default time is midnight.
Passingbyposts

#604 May 9, 2021, 10:52 AM Source

its not end of the world but i just need to tag everything i guess in was just curious what changed
Fortunastreet

#605 May 9, 2021, 12:15 PM Source

By default, dark area are colored in #000000 (pitch dark).
As precised in the help file, if you want dark areas to have another colour (let's say #666666, dark gray), you have to use the 'Tint set color' plugin command, in my example Tint set #666666. For MZ, it is the 'Set tint' plugin command.

The 'Daylight' only effect is to replace the pitch black (or whatever colour you choosed with the previous command) lighting by a night/day circle.
Aesica

#606 May 9, 2021, 06:28 PM Source

Monkeynugget said:
Quick Question : I finally ported over the latest build into my main project going from V3.2 to V4.2 seems i missed a few versions but i noticed now that unlike previously

Any map that doesnt have this map notetag is now pure darkness, which is weird

ANyone know what would be driving that
View attachment 188787
That's weird. Does it do that even if you set a map tint?
Passingbyposts

#607 May 10, 2021, 09:37 AM Source

Aesica said:
That's weird. Does it do that even if you set a map tint?
Yes that works,

It's odd as it means that the lighting system is on (pitch black) even if no map note tag is present which is odd, as that use to be a hard requirement.

It just means all maps are dungeon black if i dont note tag the map.

In some ways this is cool as it means all dungeon maps are jet black except external lighting events by default. :kaojoy:

Though with as many maps as i have in the main project note tag'ing them all is :kaoangry:
Fortunastreet

#608 May 10, 2021, 10:18 AM Source

Monkeynugget said:
Yes that works,

It's odd as it means that the lighting system is on (pitch black) even if no map note tag is present which is odd, as that use to be a hard requirement.

It just means all maps are dungeon black if i dont note tag the map.

In some ways this is cool as it means all dungeon maps are jet black except external lighting events by default. :kaojoy:

Though with as many maps as i have in the main project note tag'ing them all is :kaoangry:

What exactly do you want to accomplish? I don't get your point.
Aesica

#609 May 10, 2021, 11:48 AM Source

Monkeynugget said:
Yes that works,

It's odd as it means that the lighting system is on (pitch black) even if no map note tag is present which is odd, as that use to be a hard requirement.

It just means all maps are dungeon black if i dont note tag the map.

In some ways this is cool as it means all dungeon maps are jet black except external lighting events by default. :kaojoy:

Though with as many maps as i have in the main project note tag'ing them all is :kaoangry:
Oh wait I think I see what's going on. In one of the more recent updates, a thing was added to tint maps even if no light note tag is present on an event, etc. I'm pretty sure you can turn this off though if you prefer the old behavior.
Passingbyposts

#610 May 10, 2021, 02:32 PM Source

Aesica said:
Oh wait I think I see what's going on. In one of the more recent updates, a thing was added to tint maps even if no light note tag is present on an event, etc. I'm pretty sure you can turn this off though if you prefer the old behavior.
What setting is that exactly?
Fortunastreet

#611 May 10, 2021, 02:46 PM Source

Monkeynugget said:
What setting is that exactly?

It is called 'Light event required'.
If set to true, an event with a light notetatg is required to make the plugin works on a particular map (as in the original TerraxLighting).
If set to false, the plugin will be active on any map.

It is set to false by default.
Passingbyposts

#612 May 10, 2021, 03:48 PM Source

Cheers, i checked it out, it works but also breaks the ability to run your lighting from parallel common events instead of a lighting event.

Again no biggy as you just have to put a throwaway event in each map

i can see what that feature was trying to do but it should probably have been 'no lighting event or map note tag' to keep existing functionality intact
Fortunastreet

#613 May 11, 2021, 09:05 AM Source

I guess that is why Aesica precised to add a dummy light notetag to page based light events.
Aesica

#614 May 11, 2021, 05:08 PM Source

Monkeynugget said:
Again no biggy as you just have to put a throwaway event in each map
You could always use it for other things too, such as performing previous-map-effect cleanup, setting up various things specific to this map, etc. My empty light events (usually put in the upper-left corner to find easily) also do a host of things like removing previous-map weather effects, reset certain temporary variables, relocate events based on specific plot timeline variables, set regionId glows specific to this map, etc.

In short, the event doesn't have to go to waste. :)
DarkSearinox92

#615 May 12, 2021, 10:14 AM Source

Aesica said:
You know, hearing it this way has me thinking--maybe it's just MV's internal throttling that happens when you do any number of things that make it think "this is too much to handle at 60fps" I know you could also trigger a laggy framerate drop just by spam opening/closing the menu a bunch of times.

I see what's happening now and it was very easy to reproduce. That's easy enough to fix, so I'll add it in next time I do plugin stuff. Thanks for catching it!

Hey @Aesica , i see that you've updated the script on 4.2 but i think that you missed the problem that i posted on post 559 xD

I was thinking ... why not also insert a plugin setting where you can put a default RegionBlock, where you can select idregion and tint, so that the plugin applies the option directly, without having to run it in the game every time that you lunch it, for test for example? Obviously, if you were to change the color or the region during the game, this data would replace the previous ones configured in the plugin.

However, I find it stupid to change this data on that specific configured id region. The Region Block usually only uses it on top of walls and in those areas where the light "shouldn't come".

Maybe we can call this Region Block a Special Fixed region block?

But every time you start the game, maybe even during the tests, you have to launch the command by hand. Maybe a default value would suit us and be useful. I think it's easy to add.

What do you think about it?
Aesica

#616 May 12, 2021, 10:26 AM Source

Which one?
Passingbyposts

#617 May 12, 2021, 11:35 AM Source

Aesica said:
You could always use it for other things too, such as performing previous-map-effect cleanup, setting up various things specific to this map, etc. My empty light events (usually put in the upper-left corner to find easily) also do a host of things like removing previous-map weather effects, reset certain temporary variables, relocate events based on specific plot timeline variables, set regionId glows specific to this map, etc.

In short, the event doesn't have to go to waste. :)
Ah yes that is true, i also have a janitor event in the top left normally in most maps :kaojoy:
DarkSearinox92

#618 May 12, 2021, 01:35 PM Source

Aesica said:
Which one?

MV - Community Lighting MV & MZ
This.

However you didn't tell me what do you think about the idea :(
Aesica

#619 May 12, 2021, 07:36 PM Source

I'm confused. I don't really see what "idea" you're talking about. As for the lag, I can't reproduce it so it might be related to your hardware specs. Lighting plugins in general add overhead to RM projects.
RyanYe

#620 May 14, 2021, 02:59 AM Source

This plugin is far better than terrax one, thank you!
But i want a plugin command that can change the flashlight for "event" in the middle of game , just like characters.

is it possible?