[YEP] Yanfly Engine Plugins

First off let me say great plugins Yanfly.

I've found an issue with the coding on one of them though. I've read what you want for bug reports, and I'll give you most of it. I don't feel like it really requires a project demo though, as I'm going to show you the exact lines that are the problem. and an example of how to resolve the issue. If you however feel that is not enough feel free to ignore the issue. So here goes.

Plugin Name: YEP_X_AttachAugments.js
Plugin Parameter Changes: None
Bug Explanation: The ParamRate Boost (Param: +x%, Param: -x%) never goes down due to the coding surrounding how you calculate the paramRate. If you create an augment with the ParamRate when the augment is removed it never removes the boost, below i've wrote a patch to fix this issue, feel free to use it as is or rewrite it to suit your wishes, or come up with your own fix if you wish. I'm merely including it so show the issue, and how I resolved it.

Way to reproduce the issue would be create an item with the following notetag, the attack will only increase between equiping and removing the augment.



The issue lies on line: 1283 when it sets the value to value/100 + 1
The issue here is that a Atk: +20% would equal 1.2 and a Atk: -20% would equal 0.8. Now those are the correct rates, however following the code down to on line:985 you go into the delete method which is on line:1002 which all works correctly until it goes to check the equality of the traits. You see on line:1013 of the ItemManager.getMatchingTraitIndex method it checks to remove 0.8 but 0.8 is not the value of the trait it should remove, it should be looking for a trait with 1.2. I really hope I'm explaining this coherently. Anyways what I've done to resolve this is simple, during the adjustItemTrait method I've added a check to see if the code is a Trait_Param and if it is i adjust it to look for the opposite. Such as looking for 1.2 instead of 0.8. Now as I'm not the person who wrote the code you may find a better way to fix the issue, but if you want a simple copy and paste fix i've included what I wrote up.



I hope this helps if anything is unclear let me know I'll try to clear it up.

Introduction



Skills in RPG’s consist of three main components: Costs, Damage, and Effects. Although not all components are required for a skill, they certainly make up a good chunk of it. Damage will be handled by another plugin, but this plugin will provide a core handling for skill costs and skill effects.



This plugin also includes the ability for battlers to swap their HP, MP, and/or TP gauges for something different if it would fit the character better (for example, some classes don’t use MP and/or TP).



Notetags



These notetags can adjust either skill costs or special skill effects.



Skill Notetags:

<HP Cost: x>

Changes the skill to have x as its HP cost. RPG Maker MV’s editor lacks HP cost functions so this would allow skills to use HP as their cost.



<HP Cost: x%>

Changes the skill to cost a percentage of the character’s MaxHP value.



<MP Cost: x>

Changes the skill to have x as its MP cost. This helps bypass the database’s hard limit of 9999.



<MP Cost: x%>

Changes the skill to cost a percentage of the character’s MaxMP value.



<TP Cost: x>

Changes the skill to have x as its TP cost. This helps bypass the database’s hard limit of 99.



<TP Cost: x%>

Changes the skill to cost a percentage of the character’s MaxTP value. Although the default MaxTP is 100, this tag will be useful for any plugins that will alter a character’s MaxTP values.



Gauge Swapping



This plugin also lets you swap around the HP, MP, and TP Gauges to any order you want assuming that all the plugins you use will keep the same order of HP, MP, and TP and does not override the default gauge drawing process. If you use any plugin extensions, they can be swaped in as well.



Note: If you do not have ‘Display TP in Battle’ checked under the System tab in the database, nothing will be shown for the third slot.



Class Notetag:

<Swap Gauge x: y>

This will change gauge x (1, 2, or 3) to y. Replace y with ‘HP’, ‘MP’, or ‘TP’ to have it display that gauge type in that gauge slot. If you wish for that slot to display nothing, insert ‘Nothing’ or ‘Null’ in place of y in the notetag.



Weapon, Armor, and State Notetags:

<Swap Gauge x: y>

Actors with equipment or states that contain these notetags or enemies with states that contain these notetags will display those swapped gauges in place of the default settings or settings defined by the Class or Enemy notetags.



Priority will go in the following order: Weapons, Armors, States, Class, Enemy



Lunatic Mode – Skill Costs



For users who want more control over skill costs and skill effects, there exists notetags that allow you to apply code to the costs and/or effects of a skill. For effects, this will also extend towards item control, as well.



<Custom HP Cost>

code

code

</Custom HP Cost>

This allows the skill to have a custom HP cost based off of code. For the piece of code, ‘cost’ is a variable already predefined with the HP Cost and the HP percentage cost.



<Custom MP Cost>

code

code

</Custom MP Cost>

This allows the skill to have a custom MP cost based off of code. For the piece of code, ‘cost’ is a variable already predefined with the MP Cost and the MP percentage cost.



<Custom TP Cost>

code

code

</Custom TP Cost>

This allows the skill to have a custom TP cost based off of code. For the piece of code, ‘cost’ is a variable already predefined with the TP Cost and the TP percentage cost.



Lunatic Mode – The Skill Phases



For this skill, multiple effects are applied and at different phases. The various phases are as follows:



Before Effect Phase (influenced by this plugin)

if skill successfully lands:

– Pre-Damage Effect Phase (influenced by this plugin)

– Damage Phase

– Post-Damage Effect Phase (influenced by this plugin)

– Item Trait Effects Phase

After Effect Phase (influenced by this plugin)



There’s four phases which can be influenced by this plugin. Two of which do not matter if the effect successfully lands or not, two of which do matter if the skill does land.



Skill and Item Notetags:

<Before Eval>

code

code

</Before Eval>



<Pre-Damage Eval>

code

code

</Pre-Damage Eval>



<Post-Damage Eval>

code

code

</Post-Damage Eval>



<After Eval>

code

code

</After Eval>



If you wish to use custom effects for your skill, you can insert the respective notetags into the skill (or item) noteboxes and it will run the code that appears in between the tags. However, using any form of comments in this tag will block out code that follows.