DoubleX RMVXA Bug Fixes to YSA Battle System: Classical ATB

DoubleX · 2014-01-10T17:52:47+0900

DoubleX RMVXA Bug Fixes v1.05b to YSA Battle System: Classical ATB by DoubleX Note v1.03a+ disables party escape while at least 1 battler is executing actions Compatibility Fix http://www.rpgmakervxace.net/topic/21113-doublex-rmvxa-compatibility-fixes-to-ysa-battle-system-classical-atb/?p=145964 Prerequisites YSA Battle System: Classical ATB(Created by Yami) Introduction Tries to fix bugs I've found in YSA Battle System: Classical ATB Fixing compatibility issues isn't this script's aim Spoiler Advices - Fix some issues by following the ordering of YEA scripts: Check http://yanflychannel.wordpress.com/rmvxa/ and follow the ordering - Fix bugs when preemptives or susprises occur in the catb battle system: Give numbers to PREEMTIVE_ATB_ACTOR, PREEMTIVE_ATB_ENEMY, SURPRISE_ATB_ACTOR and SURPRISE_ATB_ENEMY - Fix some compatibility issues with other scripts: Put this script below YSA Battle System: Classical ATB, which should be put below Yanfly Engine Ace - Ace Battle Engine They should be placed as nearby each other as possible Bugs tried to fix: - (v1.05a)Buff/Debuff removal bug Buffs and debuffs won't be removed even when their remaining turns reaches 0 - (v1.04a+)Victory defeat bug: Windows that are supposed to be closed don't close if they are shown right before victory or defeat - (v1.03a+)Battler escape bug: Various crashes may occur when any battler escapes - (v1.02a+)Collapse check bug: Enemy sprite won't collapse when they die because of slip damage per turn Causes: Consider the following parts of method process_catb and perform_catb_action under class Scene_Battle respectively(YSA Battle System: Classical AT: if $game_system.catb_turn_type == :tick @tick_clock = if !@tick_clock @tick_clock += 1 if @tick_clock >= $game_system.catb_tick_count @tick_clock = all_battle_members.each { |battler| battler.on_turn_end } @status_window.refresh $game_troop.increase_turn endend Code: if $game_system.catb_turn_type == :action @tick_action = if !@tick_action @tick_action += 1 if !forced || (forced && YSA::CATB::FORCE_ACTION_COUNT) if @tick_action >= $game_system.catb_after_action @tick_action = all_battle_members.each { |battler| battler.on_turn_end } @status_window.refresh $game_troop.increase_turn endend As the collapse effect due to slip damage KO is checked per turn end and of the whole battle and YSA Battle System: Classical ATB simply get rid of the latter, the collapse check bug occurs as the above 2 parts didn't check the collapse effect when they're the only appropriate parts to do so. - (v1.01a+)On turn end bug: The whole "on turn end thing" of the whole battle simply won't be triggered at all in catb battle system Causes: Spoiler Consider the following parts of method process_catb and perform_catb_action under class Scene_Battle respectively(YSA Battle System: Classical AT: if $game_system.catb_turn_type == :tick @tick_clock = if !@tick_clock @tick_clock += 1 if @tick_clock >= $game_system.catb_tick_count @tick_clock = all_battle_members.each { |battler| battler.on_turn_end } @status_window.refresh $game_troop.increase_turn endend Code: if $game_system.catb_turn_type == :action @tick_action = if !@tick_action @tick_action += 1 if !forced || (forced && YSA::CATB::FORCE_ACTION_COUNT) if @tick_action >= $game_system.catb_after_action @tick_action = all_battle_members.each { |battler| battler.on_turn_end } @status_window.refresh $game_troop.increase_turn endend They're the ways to set how turns work under DEFAULT_TURN = :tick && :action respectively, so "on turn end" of the whole battle should be triggered here. But in fact they just trigger on turn end for all battlers only but not the whole battle also, causing things triggered at "on turn end" of the whole battle won't be triggered at all. - Autobattle flag and confusion bug: Battlers simply won't make actions automatically under the above conditions. Causes: Spoiler Consider the following part of method process_catb under class Scene_Battle(YSA Battle System: Classical AT: BattleManager.action_list.each { |battler| battler.make_actions if battler.enemy? perform_catb_action(battler) if !@subject} battler.make_actions causes battlers to make actions automatically. As it triggers only if battlers are enemies and actors aren't, actors won't make actions automatically. Consider the attempted fix by Yami to this problem: BattleManager.action_listactor).each { |battler| battler.make_actions if (battler.actor? && !battler.input)} battler.input is initially nil, but after battler.make_actions it's not nil anymore, even after the action is executed. Battler.input remains not nil at the second and later times the battler attempts to make actions, causing failure to make actions. This explains why autobattle or confusion actions only take place once. - Left arrow output bug: The left arrow output should be going left in the list of living members, but is in fact the same as that of ESC. Causes: Spoiler Consider the following part of method process_dir4 under class…

● ARCHIVED · READ-ONLY

Started by DoubleX Jan 10, 2014, 08:52 AM 20 posts View original ↗