MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 51 of 64 View original ↗

snaphat

#1001 Oct 5, 2022, 03:40 AM Source

montehawks said:
Checked out the demo.. noticed that the lighting effect disappears if my character is standing 10-12 blocks away from it. Is there a way to increase this draw distance?
Yeah there's a draw distance in the options. I had the same confusion as well. I don't remember the option name but you'll find it toward the bottom
Dark_Ansem

#1002 Oct 14, 2022, 09:09 AM Source

I'm at work rn so can't test it, but does this have dynamic shadow generation?
Deleted member 178375

#1003 Oct 16, 2022, 12:40 PM Source

Hello, I use MV. I'd like confirmation that this is compatible with Moghunter's Time System plugin, as I noticed someone mention some dozens of posts ago that due to the ticks being different between them, trying to sync the two sacrifices functionality from Mog's. I'd like to avoid that if possible, because the changing of seasons will be important for my game.

Instead of operating off Community Lighting's time progression, I'd like to operate off Mog's and have Community Lighting tint accordingly with the time of day.

Also, apparently Terrax implemented some compatibility that does not currently work, hence my interest in using Community Lighting instead; I've followed along the instructions I copypasted from the original file into this post, but to no avail. I have even tried making the variables the same.
UncreativeMedia

#1004 Oct 20, 2022, 03:19 PM Source

First of all: Amazing plugin, ll be switching to this one from now on, I truly wish I'd found it sooner ;-;

I'm having an issue with this plugin, whenever I try to load a save file I get this screen:

EDIT: This is happening in new projects and in the Demo as well. :(

TypeError
twosnakes

#1005 Oct 21, 2022, 04:48 AM Source

The persistent trouble with Z-levels. Any ideas on how I can get Khas Hint/Tutorial System to show-up higher than the lighting layers? Plugin order had no effect.
Khas Hint/Tutorial System
MaGicBush

#1006 Oct 23, 2022, 05:38 PM Source

UncreativeMedia said:
First of all: Amazing plugin, ll be switching to this one from now on, I truly wish I'd found it sooner ;-;

I'm having an issue with this plugin, whenever I try to load a save file I get this screen:

EDIT: This is happening in new projects and in the Demo as well.

TypeError
View attachment 243070

Yea I just tried this and having the same error when loading saves in my game, and the demo as well. Great plugin though if that gets to working!

*edit* I also tried Snaphat's version and get the same bug.

I also am having issues, but I am probably doing something wrong since it works fine on a new project I tested. I tried turning my other plugins off on my project, and it just seems buggy to me. Like the screen is tinted black, and the light around the player works fine(I set it to 100), but no other light sources seem to work right. I tried to set an event with a fire animation, and set the note tag to <cl: fire 300 #ffa500> and it does nothing. I then set a NPC to <cl: light 350 #ffffff>, and there is a light there, but it's very small(much smaller than the 350). Changing the radius doesn't change anything.

I then tried deleting the fire, and remaking it and I used light instead of fire, and it worked when I tested the game. But then I changed it back to fire, and now it wont work if I set it to fire or light. Using the plugin command to tint the screen doesn't seem to work either. I also tried a flashlight how the demo does it, and there is no light whenever I use it. It's like the plugin is half working. Something is conflicting I think, but I have no idea since all other plugins are off. I tried the latest plugin from github, and snaphat's version. Same issue on both. I also tried the "releases build" from May, and it just gives an error and wont load at all. Also note this project I converted from MV to MZ today since I just bought MZ and ported my project over. I wasn't to far along only having several maps done and plugins. I used the Terrax lighting system from MV previously, and figured I would try this one for MZ now. Thanks for any help or suggestions!
Aesica

#1007 Nov 2, 2022, 11:35 PM Source

Okay so somebody did a bunch of weird with the clone function (among other things) since I last looked at the code. There's no checks for potential null/undefined values, and when/if one comes up (which seems to be the case on a loaded save) then...boom.

If you guys (MV users, didn't test the MZ version) don't mind rolling back to 4.2, you can use the version on my personal github which should work. Note that saved games made with the newest version won't work, but you should be able to save and then reload your save just fine with 4.2.
Dope

#1008 Nov 8, 2022, 03:59 AM Source

Using the MZ version, 4.6 I believe, but for whatever reason lights cannot be changed once turned on. I read that the plugin is supposed to prioritize comment tags, assuming they're first, but once I activate a light on a specific page of an event, even if I change the page, the event won't update the light. No matter what, lights keep whatever setting they receive first and will not change. Event note tags will also always trump page comment tags too as far as I can tell. If I give a light settings via the event note, nothing I put in a comment tag seems to matter.
Danatoth

#1009 Nov 8, 2022, 08:49 AM Source

Aesica said:
Okay so somebody did a bunch of weird **** with the clone function (among other things) since I last looked at the code. There's no checks for potential null/undefined values, and when/if one comes up (which seems to be the case on a loaded save) then...boom.

If you guys (MV users, didn't test the MZ version) don't mind rolling back to 4.2, you can use the version on my personal github which should work. Note that saved games made with the newest version won't work, but you should be able to save and then reload your save just fine with 4.2.
Crashing here too on mv because of the clone error. Where would we find your personal github to grab 4.2?
matthewwells

#1010 Nov 12, 2022, 07:01 PM Source

KawaiiKid said:
Crashing here too on mv because of the clone error. Where would we find your personal github to grab 4.2?

I found it here: https://github.com/Aesica/community_lights
Ryuukun

#1011 Nov 15, 2022, 07:04 PM Source

Hey! So I was using 4.6 until it began crashing on me while testing my project... So I did a roll back as advised, but now when I go to a map with plugin command "light activate" it gives me a "TypeError - cannot read property 'r' of null.

I did as mentionned above, made a new save in game, and then reloaded, but to no avail...

EDIT: Wait, by new save, do you guys mean start a fresh new save? Cause I tried that, and that seems to do the trick... ?
Aesica

#1012 Nov 16, 2022, 01:10 PM Source

Ryuukun said:
Hey! So I was using 4.6 until it began crashing on me while testing my project... So I did a roll back as advised, but now when I go to a map with plugin command "light activate" it gives me a "TypeError - cannot read property 'r' of null.

I did as mentionned above, made a new save in game, and then reloaded, but to no avail...

EDIT: Wait, by new save, do you guys mean start a fresh new save? Cause I tried that, and that seems to do the trick... ?
Yeah I meant start a new game on the title screen, then save it. I'm guessing the latest version saves a few things in a way that don't make sense to the older version. That said, as much as I'm annoyed by the weird way in that the latest stuff was coded (and completely refactored) compared to the rest of the plugin, there's some pretty great stuff (specifically, the gradual light transitions) so at some point, I'll take a look at it if hat dude doesn't see this and fix it first. :) My older version (4.2) does not have that feature, so be aware of that.
ImaginaryVillain

#1013 Nov 17, 2022, 07:39 AM Source

For those having a problem, please go to https://github.com/ImaginaryVillain/community_lights/releases
and download 4.6 for your respective engine. The code on the main page never had it's version updated by the last person who did massive work on it. It's more accurate to say it's version 5+. Until now I haven't tested it, but with such drastic changes to it since I last looked, it will take some time to figure out what's wrong. So until then, get actual 4.6.
matthewwells

#1014 Nov 17, 2022, 01:42 PM Source

ImaginaryVillain said:
For those having a problem, please go to https://github.com/ImaginaryVillain/community_lights/releases
and download 4.6 for your respective engine. The code on the main page never had it's version updated by the last person who did massive work on it. It's more accurate to say it's version 5+. Until now I haven't tested it, but with such drastic changes to it since I last looked, it will take some time to figure out what's wrong. So until then, get actual 4.6.

Thanks for this link! I just integrated this version of 4.6, and so far so good!
Aesica

#1015 Nov 18, 2022, 05:54 AM Source

Just an update, I've been going over this and there's a lot more problems going on than just the clone() error. It's not saving properly in certain situations, daynight lighting isn't triggering properly after map transitions, and a few other things seem to have imploded as well. This might take a bit more time than expected, but hopefully the transitional lighting will be worth it in the end.

Definitely a thisisfine.jpg moment.
snaphat

#1016 Nov 21, 2022, 12:14 AM Source

UncreativeMedia said:
First of all: Amazing plugin, ll be switching to this one from now on, I truly wish I'd found it sooner ;-;

I'm having an issue with this plugin, whenever I try to load a save file I get this screen:

EDIT: This is happening in new projects and in the Demo as well. :(

TypeError
View attachment 243070

Just pushed a fix for this. RPGMaker wasn't reconstructing the typing on load (I should have realized this would be the case given the json loader).

Save fixes by snaphat · Pull Request #108 · ImaginaryVillain/community_lights
snaphat

#1017 Nov 21, 2022, 12:19 AM Source

Aesica said:
Just an update, I've been going over this and there's a lot more problems going on than just the clone() error. It's not saving properly in certain situations, daynight lighting isn't triggering properly after map transitions, and a few other things seem to have imploded as well. This might take a bit more time than expected, but hopefully the transitional lighting will be worth it in the end.

Definitely a thisisfine.jpg moment.

Just fixed the saving issue (this is also the clone issue). I'll test the daynight transitions shortly. Can you give a list of any other issues you've found? Thanks!

Edit: daynight lighting should be fixed on transition as well with this https://github.com/ImaginaryVillain/community_lights/pull/109
Aesica

#1018 Nov 21, 2022, 01:32 AM Source

snaphat said:
Just fixed the saving issue. I'll test the daynight transitions shortly. Can you give a list of any other issues you've found? Thanks!

Edit: daynight lighting should be fixed on transition as well with this https://github.com/ImaginaryVillain/community_lights/pull/109
Improper radius parsing, daynight failure on transition, saving failure due to circular references, daynight not starting when loading/new-gaming into a daynight map were among the main issues that came to mind. I was actually partway through fixing them too, as well as a few other fixes/additions of my own, but I'll wait until your fixes are all in first.
snaphat

#1019 Nov 21, 2022, 02:03 AM Source

twosnakes said:
The persistent trouble with Z-levels. Any ideas on how I can get Khas Hint/Tutorial System to show-up higher than the lighting layers? Plugin order had no effect.
Khas Hint/Tutorial System
Try this. It adds a sorting layer option to the CL plugin options. Setting it to 1 seems to do the trick. The general issue is that normally CL adds itself as the last layer on updates so isn't fixable outside of CL
GitHub - snaphat/community_lights at sort_layer
If it works, I'll put it as a PR
snaphat

#1020 Nov 21, 2022, 02:04 AM Source

Aesica said:
Improper radius parsing, daynight failure on transition, saving failure due to circular references, daynight not starting when loading/new-gaming into a daynight map were among the main issues that came to mind. I was actually partway through fixing them too, as well as a few other fixes/additions of my own, but I'll wait until your fixes are all in first.
They got merged so I think it's good to go (to add your changes).

Apologies for the saving issue. I did not test that. And yup, the circular refs I added was part of the saving issue + generally most of the (current map) light data not being saved as part of a save game + typing being lost on load