MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 45 of 64 View original ↗

Fortunastreet

#881 Feb 28, 2022, 08:57 PM Source
Aesica said:
I'm on the fence about this, but in the meantime, you can probably disable them by making a new plugin with this as the contents:

Code:
Tilemap.prototype._addShadow = function(){};
@Aesica I already implemented it. EDIT: It wasn't on Github yet (merge conflict + precrastination), but now the mr is live.

Skurge

#882 Mar 1, 2022, 04:08 AM Source

Sorry to get back slowly on this, it's a bit tricky to visually demonstrate it but my events in question require movement commands in the command window rather than autonomous, the reason being is they have multiple choice routes.

This is the event's page:

Code:

◆Set Movement Route：This Event (Wait)
：                  ：◇Turn Up
◆Wait：120 frames
◆Set Movement Route：This Event (Wait)
：                  ：◇Turn Up
：                  ：◇Through ON
：                  ：◇Transparent ON
◆Wait：100 frames
◆Script：this._carShown = Math.floor(Math.random() * 2) + 1;
◆Comment：[ CAR IS REVEALED ]
◆If：Script：this._carShown === 1
  ◆Set Event Location：This Event, (4,28) (Direction: Up)
  ◆Script：thisEvent = $gameMap.event(this._eventId);
  ：      ：thisEvent._randomlyChosenCharacterName = "Car" + (Math.floor(Math.random() * 8) + 1);
  ：      ：thisEvent._randomlyChosenCharacterIndex = Math.floor(Math.random() * 8);
  ：      ：thisEvent.setImage(thisEvent._randomlyChosenCharacterName, thisEvent._randomlyChosenCharacterIndex);
  ◆Set Movement Route：This Event (Wait)
  ：                  ：◇Through OFF
  ：                  ：◇Opacity：0
  ：                  ：◇Transparent OFF
  ：                  ：◇Opacity：50
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：100
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：150
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：200
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：255
  ◆Set Movement Route：This Event (Wait)
  ：                  ：◇Script：SirL.MPdEST.trigger(this, "['Traffic Light'].includes($dataMap.events[event._eventId].name) && !selfSwitches['B']",{},[0],{"A":true})
  ：                  ：◇Speed：4
  ：                  ：◇Script：SirL.MPRepeatNext.move(this, 7)
  ：                  ：◇Move Up
  ：                  ：◇Speed：3
  ：                  ：◇Script：SirL.MPRepeatNext.move(this, 3)
  ：                  ：◇Move Up
  ：                  ：◇Speed：4
  ：                  ：◇Script：SirL.MPRepeatNext.move(this, 5)
  ：                  ：◇Move Up
  ：                  ：◇Move Upper Right
  ：                  ：◇Script：SirL.MPRepeatNext.move(this, 43)
  ：                  ：◇Move Right
  ◆Set Movement Route：This Event (Wait)
  ：                  ：◇Opacity：200
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：150
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：100
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：50
  ：                  ：◇Transparent ON
  ◆Set Event Location：This Event, (44,28) (Direction: Up)
  ◆
：End
◆Comment：[ CAR IS NOT REVEALED FOLLOWING DELAYED LOOP]
◆If：Script：this._carShown === 2
  ◆Set Event Location：This Event, (44,28) (Direction: Up)
  ◆Set Movement Route：This Event (Wait)
  ：                  ：◇Turn Up
  ◆Wait：100 frames
  ◆
：End

This is the result:

By all accounts, the light should be updating the moment a move route command is issued (face up)
but for whatever reason I can't figure out why it updates a few steps in? It might be because the move route is using a script to condense commands but I want to find out the imput here.

Thanks for your concern.

*EDIT*
Checked with a few tests with Sirlegna (the one behind the move route script) we can verify it's nothing to do with these*

My version is 4.2 btw.

Aesica

#883 Mar 1, 2022, 08:16 AM Source

Skurge said:

Code:

◆Set Movement Route：This Event (Wait)
：                  ：◇Turn Up
◆Wait：120 frames
◆Set Movement Route：This Event (Wait)
：                  ：◇Turn Up
：                  ：◇Through ON
：                  ：◇Transparent ON
◆Wait：100 frames
◆Script：this._carShown = Math.floor(Math.random() * 2) + 1;
◆Comment：[ CAR IS REVEALED ]
◆If：Script：this._carShown === 1
  ◆Set Event Location：This Event, (4,28) (Direction: Up)
  ◆Script：thisEvent = $gameMap.event(this._eventId);
  ：      ：thisEvent._randomlyChosenCharacterName = "Car" + (Math.floor(Math.random() * 8) + 1);
  ：      ：thisEvent._randomlyChosenCharacterIndex = Math.floor(Math.random() * 8);
  ：      ：thisEvent.setImage(thisEvent._randomlyChosenCharacterName, thisEvent._randomlyChosenCharacterIndex);
  ◆Set Movement Route：This Event (Wait)
  ：                  ：◇Through OFF
  ：                  ：◇Opacity：0
  ：                  ：◇Transparent OFF
  ：                  ：◇Opacity：50
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：100
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：150
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：200
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：255
  ◆Set Movement Route：This Event (Wait)
  ：                  ：◇Script：SirL.MPdEST.trigger(this, "['Traffic Light'].includes($dataMap.events[event._eventId].name) && !selfSwitches['B']",{},[0],{"A":true})
  ：                  ：◇Speed：4
  ：                  ：◇Script：SirL.MPRepeatNext.move(this, 7)
  ：                  ：◇Move Up
  ：                  ：◇Speed：3
  ：                  ：◇Script：SirL.MPRepeatNext.move(this, 3)
  ：                  ：◇Move Up
  ：                  ：◇Speed：4
  ：                  ：◇Script：SirL.MPRepeatNext.move(this, 5)
  ：                  ：◇Move Up
  ：                  ：◇Move Upper Right
  ：                  ：◇Script：SirL.MPRepeatNext.move(this, 43)
  ：                  ：◇Move Right
  ◆Set Movement Route：This Event (Wait)
  ：                  ：◇Opacity：200
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：150
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：100
  ：                  ：◇Wait：1 frame
  ：                  ：◇Opacity：50
  ：                  ：◇Transparent ON
  ◆Set Event Location：This Event, (44,28) (Direction: Up)
  ◆
：End
◆Comment：[ CAR IS NOT REVEALED FOLLOWING DELAYED LOOP]
◆If：Script：this._carShown === 2
  ◆Set Event Location：This Event, (44,28) (Direction: Up)
  ◆Set Movement Route：This Event (Wait)
  ：                  ：◇Turn Up
  ◆Wait：100 frames
  ◆
：End

Are your events set to "Fixed" movement, and are being moved by something else like a parallel process? If so, change their move type to "Custom"

Skurge

#884 Mar 1, 2022, 03:50 PM Source

OK that seems to fix the issue i'm having, thanks! :)
My question is why does that need to be turned to custom in the first place? I figured the light would be facing the characters direction the instance it changes.
DarkSearinox92

#885 Mar 3, 2022, 08:45 AM Source
Alexandre said:
EDIT: @DarkSearinox92 I tested with nw.js version 60, and I couldn't reproduce the issue with the player light. (It is MZ here, but same result for MV). I implemented the autoshadow change however.View attachment 217698
What the hell, it's not possible... So if you implemented the autoshadow in this version, i will face the problem about the Radius Light. And i don't understand why.
Maybe i can provide to you the blank test project that i have and you can try to play directly my project. However, it's very strange because it's so damn simple and the project is blank... with only yanfly core.
If you updated it adding the autoshadow disabled when night switch is on, i definitively need to understand why it give me this joke.
Aesica said:
I'm on the fence about this, but in the meantime, you can probably disable them by making a new plugin with this as the contents:

Code:
Tilemap.prototype._addShadow = function(){};
Alexandre provided to add this function.
However, if i create your plugin, i think that the function that you provided, will completely disable the autoshadow... (is it right? I can't try it now, i'm at office).

This is not what i raccomendend.
Basically, when it's night, you will always see autoshadow, and it's not really good to see, because... if you have a tint for night (not full black, just the standard one), you will always see autoshadow. How is it possible? There are no lights, so basically you CAN'T see that shadows in the dark xD So i thought that it will be more "natural" disable autoshadow when night switch is on. And of course add the possibility to the player to chose if you want this addon or not, simple enable or disable it in the plugin.

Basically this is what i thought.

But now i need to definitively understand WHY the radius doesn't work anymore with the new version provided, and why with the old version it works perfectly..

Alexandre says that it works, in MZ and in MV, and now i'm very confused.

I will try more test and i will add here the project that i'm using, maybe i will create a new project again, with yanfly core and without yanfly core, for test it better again...

DAMN...
Fortunastreet

#886 Mar 3, 2022, 09:18 AM Source

DarkSearinox92 said:
What the hell, it's not possible... So if you implemented the autoshadow in this version, i will face the problem about the Radius Light. And i don't understand why.
Maybe i can provide to you the blank test project that i have and you can try to play directly my project. However, it's very strange because it's so damn simple and the project is blank... with only yanfly core.
If you updated it adding the autoshadow disabled when night switch is on, i definitively need to understand why it give me this joke.

Yup, please do. A blank project showing the bug (and with the code of 4.2 you are using where the bug isn't present) would help out understand what's going wrong.

DarkSearinox92 said:
Alexandre provided to add this function.
However, if i create your plugin, i think that the function that you provided, will completely disable the autoshadow... (is it right? I can't try it now, i'm at office).
It will. The code Aesica showed you is the same as the 'no auto-shadow' plugin.

PS: Did you placed the Yanfly Core above or under Community Lighting?
DarkSearinox92

#887 Mar 3, 2022, 10:20 AM Source

Alexandre said:
Yup, please do. A blank project showing the bug (and with the code of 4.2 you are using where the bug isn't present) would help out understand what's going wrong.

It will. The code Aesica showed you is the same as the 'no auto-shadow' plugin.

PS: Did you placed the Yanfly Core above or under Community Lighting?

So it's not what we are trying to do. (no auto-shadow).

Yes, i placed the yanfly core above the community lighting, of course.

I will zip the blank project with minimal rtp, for you, this evening :) Now here it's 11:20. I will send it.

Thank you very much for your effort, really <3
ilansas

#888 Mar 4, 2022, 06:23 PM Source

How can i apply this amazing plugin only in certain maps?
Nedoxu

#889 Mar 4, 2022, 07:19 PM Source

I may be stupid and missing something someone posted earlier because this has been an ongoing issue for me for a while, but for some reason the battle tinting, though it previously worked with my project, now only tints a small square of the battle window, regardless of if the tinting is due to the DayNight cycle or otherwise. It doesn't display tinting at all if set to "Between Background and Battlers". The plugin otherwise seems to work flawlessly, so this is very frustrating. The only other plugins I have installed are some of the VisuStella 8 wave bundle plugins. Using RPG Maker MZ by the way.
Fortunastreet

#890 Mar 5, 2022, 09:59 AM Source

ilansas said:
How can i apply this amazing plugin only in certain maps?
Create a parallel event who activate/desactivate the plugin with plugin commands on the concerned maps.
Fortunastreet

#891 Mar 5, 2022, 10:49 AM Source

Nedoxu said:
I may be stupid and missing something someone posted earlier because this has been an ongoing issue for me for a while, but for some reason the battle tinting, though it previously worked with my project, now only tints a small square of the battle window, regardless of if the tinting is due to the DayNight cycle or otherwise. It doesn't display tinting at all if set to "Between Background and Battlers". The plugin otherwise seems to work flawlessly, so this is very frustrating. The only other plugins I have installed are some of the VisuStella 8 wave bundle plugins. Using RPG Maker MZ by the way.
There was indeed a problem with the MZ version and the 'Between' case, I just added a pull request with this fix.
However, the offset wasn't as huge as in your screenshot, so I would imagine there may be some incompatibilities with whatever visu-plugin you installed.
RCDunn

#892 Mar 6, 2022, 09:57 PM Source

Hi, the demo doesn't seem to work. I started a fresh game and my screen isn't showing any lighting effects (see below).

I checked that the plugin was ON and I'm running the latest version of MV (1.6.2), so I'm not sure what else could be the issue?

edit: I threw the plugin in my game and still no dice. It's weird since I've been using TerraxLighting 1.5.1 with no problems so far.
BenSD

#893 Mar 6, 2022, 10:30 PM Source

sb~ said:
Hi, the demo doesn't seem to work. I started a fresh game and my screen isn't showing any lighting effects (see below).

I checked that the plugin was ON and I'm running the latest version of MV (1.6.2), so I'm not sure what else could be the issue?

edit: I threw the plugin in my game and still no dice. It's weird since I've been using TerraxLighting 1.5.1 with no problems so far.

Can confirm; I just downloaded the MV demo project to test and had the same results. I use the equivalent on my MZ project, so I know at least roughly how it's supposed to work, but I couldn't get it going in MV. Sorry, I know that doesn't help the problem, but it sounds like there's a good chance you're not doing anything wrong (unless we both are?).
Fortunastreet

#894 Mar 6, 2022, 10:43 PM Source

DarkSearinox92 said:
what we are trying to do. (no auto-shadow).

Yes, i placed the yanfly core above the community lighting, of course.

I will zip the blank project with minimal rtp,

sb~ said:
Hi, the demo doesn't seem to work. I started a fresh game and my screen isn't showing any lighting effects (see below).

I checked that the plugin was ON and I'm running the latest version of MV (1.6.2), so I'm not sure what else could be the issue?

edit: I threw the plugin in my game and still no dice. It's weird since I've been using TerraxLighting 1.5.1 with no problems so far.

View attachment 218640

schvanckque said:
Can confirm; I just downloaded the MV demo project to test and had the same results. I use the equivalent on my MZ project, so I know at least roughly how it's supposed to work, but I couldn't get it going in MV. Sorry, I know that doesn't help the problem, but it sounds like there's a good chance you're not doing anything wrong (unless we both are?).

I just downloaded the demo for mv (latest, release 4.4), and it worked as I expected.
Are you sure you downloaded the latest one, and the one matching your version of rpg maker?
RCDunn

#895 Mar 6, 2022, 10:59 PM Source

Alexandre said:
I just downloaded the demo for mv (latest, release 4.4), and it worked as I expected.
Are you sure you downloaded the latest one, and the one matching your version of rpg maker?
Hmm I downloaded it from the GitHub link on the first page. The plugin there was actually version 4.5.1.

Is there another place to download it? Maybe we aren't using the latest stable release?

edit: Ah got it to work by downloading the correct release (4.4) which is located on the right side of the GitHub page under Releases. GitHub's layout always confuses me... @schvanckque
Not sure if this also solved your problem @DarkSearinox92 ?
Fortunastreet

#896 Mar 7, 2022, 12:08 AM Source

sb~ said:
Hmm I downloaded it from the GitHub link on the first page. The plugin there was actually version 4.5.1.

Is there another place to download it? Maybe we aren't using the latest stable release?

edit: Ah got it to work by downloading the correct release (4.4) which is located on the right side of the GitHub page under Releases. GitHub's layout always confuses me... @schvanckque
Not sure if this also solved your problem @DarkSearinox92 ?
4.5.1 should be working, too.
Did you follow the download instructions? (Otherwise, you may download an html page rather than the actual plugin.)
BenSD

#897 Mar 7, 2022, 02:40 AM Source

sb~ said:
edit: Ah got it to work by downloading the correct release (4.4) which is located on the right side of the GitHub page under Releases. GitHub's layout always confuses me... @schvanckque
Not sure if this also solved your problem @DarkSearinox92 ?
Yeah, I definitely did the same thing, so there's the problem. Glad you got it working!
RCDunn

#898 Mar 7, 2022, 09:21 AM Source

Alexandre said:
4.5.1 should be working, too.
Did you follow the download instructions? (Otherwise, you may download an html page rather than the actual plugin.)
I downloaded a zipped file called community-lights_master with both the MV and MZ demos in it, so I believe it was the right one. Given that schwanckque and I couldn't get 4.5.1 working but have no problems with 4.4, I would guess that there's something missing with the latest version.
Fortunastreet

#899 Mar 7, 2022, 11:38 AM Source

sb~ said:
I downloaded a zipped file called community-lights_master with both the MV and MZ demos in it, so I believe it was the right one. Given that schwanckque and I couldn't get 4.5.1 working but have no problems with 4.4, I would guess that there's something missing with the latest version.

I manage to reproduce the error, there is something weird with the version number, I will push a fix soon.
DarkSearinox92

#900 Mar 7, 2022, 12:36 PM Source

Alexandre said:
Yup, please do. A blank project showing the bug (and with the code of 4.2 you are using where the bug isn't present) would help out understand what's going wrong.

It will. The code Aesica showed you is the same as the 'no auto-shadow' plugin.

PS: Did you placed the Yanfly Core above or under Community Lighting?

Hey friend, i found the damn bug. If you set the Player Radius <100, the raidus stop to work! That's the problem :(