MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 37 of 64 View original ↗

ImaginaryVillain

#721 Oct 1, 2021, 04:13 AM Source

@Mladjone
Change your screen size settings in the plugin parameters to match whatever screen size you're targeting. :LZSwink::thumbsup-right:

Alexandre said:
Ok, I was wondering why so many were reverted on Github, now I understand why.
I never realised how similar 'l' and '1' were in Notepad++.

@ImaginaryVillain Totally agree to have a kind of 'release version', I already kinda followed this mentality by only putting known stable version of the plugin in the demos the last time I updated them. It is probably why the bug wasn't reported before or Mladjone didn't experienced it with the demo, as the demos were free of it. I see most of the reverts are still active, it is normal?
Probably what happened. Anyway, I've created releases for each version. From now on I'll just make certain to at least test people's changes beforehand. Not going to lie, I don't even use the engine anymore. So I kind of fell out of the habit. But it's probably a good idea if I don't just assume people tested their code.

I've also removed the demo zip files as Github already allows for a download of the entire project as a zip. And the releases have zips attached to them, making the extra zips pointless.

As for the current state of the plugin, yes I temporarily tried reverting the plugin to get a working version. That is when I discovered I couldn't revert it back to 4.2, I just ended up going in and fixing it. Everything should be good to go. I've remerged everything, so it should be the most up to date possible.
Fortunastreet

#722 Oct 1, 2021, 07:41 AM Source

Mladjone said:
@ImaginaryVillain Hi, I have one more question. I'm not sure if it's a common bug, a problem with this version of the plugin, or just a screw-up on my part, but every light source is blocked by an invisible wall on the upper right corner.

View attachment 202789

I tried looking through the replies here, but either I've not gone far enough or I've missed a similar problem. Any way to fix this?

From what I can see, it sounds like you are using direction for your light without realizing it.
Does your light notetag contains 'd9' or 'D9' by any chance?
Mladjone

#723 Oct 1, 2021, 01:38 PM Source

Alexandre said:
From what I can see, it sounds like you are using direction for your light without realizing it.
Does your light notetag contains 'd9' or 'D9' by any chance?
That was absolutely what it was. I am a dum-dum. xD

Thanks for helping out.
fireglare

#724 Oct 4, 2021, 06:46 AM Source

This is awesome! I've been toying with this crazy setup with the legacy system to get lights on events to turn on and off after they hit you and stuff so this is really gonna save me some time!

However, from what I can see, in both the demo and my current project, the "addColorStop" issue is back.

This is taken from the console of the demo:

Console output
rpg_managers.js:1949 Error: Failed to execute 'addColorStop' on 'CanvasGradient': The value provided ('#FFFFFF3f.bffffffffffe') could not be parsed as a color. at Bitmap.radialgradientFillRect (Community_Lighting.js:1782) at Lightmask._updateMask (Community_Lighting.js:1332) at Lightmask.update (Community_Lighting.js:1012) at rpg_core.js:4068 at Array.forEach (<anonymous>) at Spriteset_Map.Sprite.update (rpg_core.js:4066) at Spriteset_Map.Spriteset_Base.update (rpg_sprites.js:2145) at Spriteset_Map.update (rpg_sprites.js:2275) at Spriteset_Map.Spriteset_Base.initialize (rpg_sprites.js:2131) at Spriteset_Map.initialize (rpg_sprites.js:2261)

Same thing occurs in my own project, but only when I enter locations with "fire" lights. I've tested both with cl and legacy support (without cl).
Fortunastreet

#725 Oct 4, 2021, 11:49 AM Source

fireglare said:
This is awesome! I've been toying with this crazy setup with the legacy system to get lights on events to turn on and off after they hit you and stuff so this is really gonna save me some time!

However, from what I can see, in both the demo and my current project, the "addColorStop" issue is back.

This is taken from the console of the demo:

Console output
rpg_managers.js:1949 Error: Failed to execute 'addColorStop' on 'CanvasGradient': The value provided ('#FFFFFF3f.bffffffffffe') could not be parsed as a color. at Bitmap.radialgradientFillRect (Community_Lighting.js:1782) at Lightmask._updateMask (Community_Lighting.js:1332) at Lightmask.update (Community_Lighting.js:1012) at rpg_core.js:4068 at Array.forEach (<anonymous>) at Spriteset_Map.Sprite.update (rpg_core.js:4066) at Spriteset_Map.Spriteset_Base.update (rpg_sprites.js:2145) at Spriteset_Map.update (rpg_sprites.js:2275) at Spriteset_Map.Spriteset_Base.initialize (rpg_sprites.js:2131) at Spriteset_Map.initialize (rpg_sprites.js:2261)

Same thing occurs in my own project, but only when I enter locations with "fire" lights. I've tested both with cl and legacy support (without cl).
I will have a look soon, it is likely the bugfix was lost between the rebases

EDIT: It was exactly that. I found what did go wrong, I made a pull request with the needed fix.
ImaginaryVillain

#726 Oct 4, 2021, 08:42 PM Source

Alexandre said:
I will have a look soon, it is likely the bugfix was lost between the rebases

EDIT: It was exactly that. I found what did go wrong, I made a pull request with the needed fix.
The pull request has been merged.
Aesica

#727 Oct 6, 2021, 08:02 AM Source

Odd, I thought this thread died or ran its course or something since I stopped getting notifications for it, even though it's on my watched list. Good to see it's still active, although what's up with the typescript definition file?
Fortunastreet

#728 Oct 6, 2021, 10:47 PM Source

It is a sort of doc in typescript, but it seems it isn't completed yet.
Passingbyposts

#729 Oct 7, 2021, 07:20 PM Source

Hi Everyone
Been awhile.
Is there a way to put a light under a tile but above a parralax?
In my example i have a transparent window in a underground train and want the light to look like its coming from outside the train.
Everything else is parralax
Aesica

#730 Oct 7, 2021, 08:17 PM Source

Passingbyposts said:
Hi Everyone
Been awhile.
Is there a way to put a light under a tile but above a parralax?
In my example i have a transparent window in a underground train and want the light to look like its coming from outside the train.
Everything else is parralax
View attachment 203335
Unfortunately, no not without getting into the code itself. The lighting is a special layer that sits above the tile layer. Best I can think of is reducing the size of the light, then possibly adding a second one beside it to fill in the window shape.
Passingbyposts

#731 Oct 8, 2021, 07:25 AM Source

Aesica said:
Unfortunately, no not without getting into the code itself. The lighting is a special layer that sits above the tile layer. Best I can think of is reducing the size of the light, then possibly adding a second one beside it to fill in the window shape.
Ah, i thought that was the case but wanted to make sure

Thanks for letting me know and glad to see you still around Aesica :ptea:
Passingbyposts

#732 Oct 9, 2021, 10:47 AM Source

Quick Question :

Maybe im being dumb
Shouldn't this force the flashlight to always point up?
As the flashlight continues to move with the direction which i thought could be disabled?
Aesica

#733 Oct 9, 2021, 12:36 PM Source

As far as I know, it only applies to immobile events. It's a pretty old bug that I (or someone else) should probably try to fix at some point. If I get a chance, I'll look at it tomorrow.
Fortunastreet

#734 Oct 9, 2021, 03:22 PM Source

Passingbyposts said:
Quick Question :

Maybe im being dumb
Shouldn't this force the flashlight to always point up?
As the flashlight continues to move with the direction which i thought could be disabled?
View attachment 203438
View attachment 203439
You are 100% right, it is a bug. @Aesica I made a pull request with the fix.
Aesica

#735 Oct 9, 2021, 06:48 PM Source

Oh nice, beat me to it. @ImaginaryVillain is the one that has to handle that though :D
ImaginaryVillain

#736 Oct 10, 2021, 05:19 AM Source

Alexandre said:
You are 100% right, it is a bug. @Aesica I made a pull request with the fix.
I've approved it.
Passingbyposts

#737 Oct 10, 2021, 09:12 AM Source

Yep, seems to be working aswell :)

Have'nt compatability tested it yet with my main project but im not expecting that will be a problem

Thanks alot Aesica , Imaginary and Alexandre :ptea:

hands down best community project on the citadel
Nichmann

#738 Oct 15, 2021, 11:03 PM Source

Is there a way to offset the flashlight on the x axis? Also, is there a way to remove the circular light around the player character when using a flashlight?
Fortunastreet

#739 Oct 19, 2021, 03:45 PM Source
Nichmann said:
Is there a way to offset the flashlight on the x axis? Also, is there a way to remove the circular light around the player character when using a flashlight?

There is the possibility to add a x or y offset to any flashlight event (the 'x' and 'y' parameters).
Code:
Flashlight [bl] [bw] [c] [onoff] [sdir] [x] [y] [id]
For the player event, there is a plugin parameter for that.

For the second question, I have no idea.
LadyBaskerville

#740 Oct 21, 2021, 11:54 AM Source

I'm very interested in the "ultra mini" version of this plugin, but I can't seem to find it on the GitHub. Am I missing something, or is it not available anymore?