MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 23 of 64 View original ↗

AfroditeOhki

#441 Dec 10, 2020, 01:23 PM Source

Aesica said:
All right, fixed a few thangs!

MV version: Updated to v2.4
MZ version: Updated to v3.5

- Fixed a bug where the player light source ignored the brightness parameter
- Restored the light offset functionality that somehow went missing. While I'm not sure how it was supposed to work originally (I couldn't find the code that actually added light offsets properly anywhere) here's how it works now:

<cl: light 250 #fff x0.5 y1>

Creates a light source that's half a tile to the right and 1 tile down

<cl: light 250 #fff y-0.5>

Creates a light source that's half a tile up

The fixed versions are on my github and should be on @ImaginaryVillain 's branch once he sees this. :)
YOU ARE GLORIOUS. Thank you so much for this! <3 do the offsets work with on-map flashlights too?
Aesica

#442 Dec 10, 2020, 07:36 PM Source

AfroditeOhki said:
YOU ARE GLORIOUS. Thank you so much for this! <3 do the offsets work with on-map flashlights too?
They should. Let me know if they don't, because if not it's an easy enough thing to fix.
AfroditeOhki

#443 Dec 11, 2020, 01:26 PM Source

Bless your heart, Aesica. <3

Edit2: ... Can I make another request? Could we get the map flashlights to work with the ID/kill switch system please? I don't know why they were left out of having IDs. xD

And for the life of me, I can't get this to work with Mog's Time System properly. Just giving them the same Hour Variable didn't work - I'm having to control time via Community Lighting and having Mog's Time get the time from that, so that my visual clock can work, but then it doesn't change the day.
DarkSearinox92

#444 Dec 14, 2020, 03:46 PM Source

So very amazing! YOU GUYS are the best of the best. I always said it. This plugin is getting incredibly beautiful!
Moon_Haven

#445 Dec 15, 2020, 07:34 PM Source

Anyone able to confirm that the processing power required for this plugin grows when increasing the radius of the lights?

For testing:
* I have a map with some 30 small lights (radius 80), my FPS doesn't drop.
* Other map has 2 lights (radius 600), I lose about 20 FPS.
Aesica

#446 Dec 16, 2020, 09:45 PM Source

Moon_Haven said:
Anyone able to confirm that the processing power required for this plugin grows when increasing the radius of the lights?

For testing:
* I have a map with some 30 small lights (radius 80), my FPS doesn't drop.
* Other map has 2 lights (radius 600), I lose about 20 FPS.
Nope, haven't had any issues with that. Just tested in a room where I use 2 really big lights @ 800 radius for ambience and subtle gradients, then in another room with about 8 lights @ 250 radius each, and I'm still at a solid 60 for both rooms.
AfroditeOhki

#447 Dec 16, 2020, 09:55 PM Source

I've only had performance issues in my main city map - which is pretty large and now stands at 99 events, some of them parallel, has moving cloud shadows going by nonstop, and some 30 map flashlights plus 4 different events for 3 locations of sun and a moon (and those have around 350 radius). But performance only drops when I increase the option to draw lights from farther away to above 22 squares.

But my computer is fairly powerful.

I haven't tried lights that large yet though - when it comes to that I just tint the entire area.
ShadowDragon

#448 Dec 16, 2020, 10:10 PM Source

@AfroditeOhki didn't though of the flashlight for a light like that, very creative and dynamic =)

@Aesica does teh plugin also work direct for the demo or will it break some lights?
or lights that isn't added to it, be able to add it in the demo as well?

I might use this plugin over ocram_lights (while he has many nice features), this one
become better in some nice ways =)
Aesica

#449 Dec 16, 2020, 10:35 PM Source

I'm pretty sure the demo could use some updating, and probably uses an older version of the plugin unless somebody else updated it (I know I haven't)

That said, dropping the latest version into it *should* work fine in the demo.
Frostorm

#450 Dec 17, 2020, 05:46 AM Source

Hey, what color do you guys use for a torch (fire)? I'm having a hard time making it look good... :/
Moon_Haven

#451 Dec 17, 2020, 03:22 PM Source

@Aesica @AfroditeOhki
Thank you! I have a potato laptop and thanks yo your posts, I found out that the map was too big so I will have to chop it down to smaller pieces.

@Frostorm
Depends on type of light and the size of it. This is what I'm using:
Small candles: https://www.colorhexa.com/cfc0ad
3 candles on a post: https://www.colorhexa.com/e3cbad
Lantern: https://www.colorhexa.com/e8dcbc
Fireplace: https://www.colorhexa.com/e1c4a9
ShadowDragon

#452 Dec 17, 2020, 05:59 PM Source

@Frostorm it depends on the color as well you use? blue fire, red fire, orange, green,
rainbow perhaps? for different vibe in dungeons, puzzles etc.

Best way is to put the tile and color in MV, use black bg, and play with colors
behind the torch that fits best for you and use that color code :)
Frostorm

#453 Dec 17, 2020, 06:03 PM Source

ShadowDragon said:
@Frostorm it depends on the color as well you use? blue fire, red fire, orange, green,
rainbow perhaps? for different vibe in dungeons, puzzles etc.
Oh, it's for the normal color of fire, as in what you'd see irl lol. I've tried various shades of yellow, oj, & red, but I can't seem to get it just right...

Moon_Haven said:
@Frostorm
Depends on type of light and the size of it.
Thanks, I'll check those out!

Edit: Omg, it's beautiful! Tyvm!! (#e1c4a9)
DarkSearinox92

#454 Dec 20, 2020, 07:35 PM Source

@Aesica @ImaginaryVillain Guys,

I report a small problem that I had also encountered in the Terrax's vanilla version.
Would it be possible to put the Tint Screen above the lights as a priority?

If the Tint screen is used, lights remain visible and are not covered :(
Aesica

#455 Dec 20, 2020, 09:48 PM Source

DarkSearinox92 said:
@Aesica @ImaginaryVillain Guys,

I report a small problem that I had also encountered in the Terrax's vanilla version.
Would it be possible to put the Tint Screen above the lights as a priority?

If the Tint screen is used, lights remain visible and are not covered :(
Do you mean the default RM tinting?
DarkSearinox92

#456 Dec 21, 2020, 08:33 AM Source

Aesica said:
Do you mean the default RM tinting?

Yes, the default one.
Aesica

#457 Dec 22, 2020, 02:54 AM Source

DarkSearinox92 said:
Yes, the default one.
I'm pretty sure the default RM tinting is done by changing the color tone of the game screen directly, so there's no way to put it over anything else. If you want lighting to be able to interact with tints, you'll have to use the plugin's tinting instead. Sorry!
Jimmy2017

#458 Dec 22, 2020, 04:10 AM Source

Hi all.

I'm trying to use this with MZ and i'm getting a bit confused on a few things. I am mainly using this plugin so that torches will have a nice fire effect.

So when I enable it, and add a fire effect, the player character then has a radius of light as well, with the remainder of the map being black. I noticed on the first page of this, OP said:

Sure plugin command Tint set #333333 (where the 333333 is any number that amuses you). Also
Tint fade #333333 will fade the current color to a new color.

However, these plugin commands don't exist that I can see, I just have on/off as an option. I tried adding these to notes on a parallel event that would normally do the default MZ tinting, but this doesn't make any difference either.

I essentially just want to have torches etc have a warming glow effect, and the rest of the appearance largely untouched.

Am I overlooking something incredibly simple here?

EDIT: Also the demo for MZ the map sets are entirely blank for me. I can select the events in the editor but cannot test anything to see how it looks.
Aesica

#459 Dec 22, 2020, 11:27 AM Source

Jimmy2017 said:
Hi all.

I'm trying to use this with MZ and i'm getting a bit confused on a few things. I am mainly using this plugin so that torches will have a nice fire effect.

So when I enable it, and add a fire effect, the player character then has a radius of light as well, with the remainder of the map being black. I noticed on the first page of this, OP said:

Sure plugin command Tint set #333333 (where the 333333 is any number that amuses you). Also
Tint fade #333333 will fade the current color to a new color.

However, these plugin commands don't exist that I can see, I just have on/off as an option. I tried adding these to notes on a parallel event that would normally do the default MZ tinting, but this doesn't make any difference either.

I essentially just want to have torches etc have a warming glow effect, and the rest of the appearance largely untouched.

Am I overlooking something incredibly simple here?
MZ plugin commands are done in a fairly straightforward way. If you have the correct plugin (the non-UMC MZ version) you should have all tlhe plugin commands available via the dropdown plugin command list. The tinting command is under "Set Tint."

Jimmy2017 said:
EDIT: Also the demo for MZ the map sets are entirely blank for me. I can select the events in the editor but cannot test anything to see how it looks.
The demos have their assets stripped to save space. You can copy the RTP assets from any new project into the demo project and it should work just fine.
Jimmy2017

#460 Dec 23, 2020, 01:32 AM Source

Hi Aesica,

Thanks so much for the reply. I actually loaded it again this afternoon after reading this and the options have all appeared now. No idea what happened before, I literally only had the 'turn on/off' as an option on the drop down, but now everything has appeared.

I'm sure I will have other questions in due course!

Thanks again :)