MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 12 of 64 View original ↗

Aesica

#221 Sep 8, 2020, 05:41 AM Source

MerlinCross said:
I've attached the ID in the proper place but the Plugin command seems to still be off.

I'm trying to turn the light off when the player hits a spot
Got screenshots of your plugin command settings + light note tag?
stevenblanc

#222 Sep 9, 2020, 12:59 AM Source

Hey guys,

Im getting this to work on test maps but its not working in game. Most likely cause: VisuStella plugins.

I have the core suite of VisuStella enabled; are there any known conflicts/workarounds?
Aesica

#223 Sep 9, 2020, 02:39 AM Source

Not sure, haven't really tried it with them. Try turning each one off and see if that affects anything.
Fortunastreet

#224 Sep 9, 2020, 08:05 AM Source

stevenblanc said:
Hey guys,

Im getting this to work on test maps but its not working in game. Most likely cause: VisuStella plugins.

I have the core suite of VisuStella enabled; are there any known conflicts/workarounds?

I never tried VS, but I can say that on MV, TerraxLighting worked perfectly fine with Yanfly's MV plugins,
so there is no reason there would be a conflict with VS, as it is basically a port of Yanfly's MV library.

Be just sure you place Community Lighting under all the VS suit. If it don't work,
try turning off VS plugins as Aesica said.
Aesica

#225 Sep 9, 2020, 09:01 AM Source

So I just tried it with the whole wad of VS plugins enabled and it works fine whether above or below them. Note that this is just the base-level free plugins, since I'm not paying for plugins just to test for compatibility. :D

Here's what plugins I had active, just for reference.
stevenblanc

#226 Sep 9, 2020, 10:20 AM Source

Hm. Can't for the life of me figure out what I've done. I created a new map within the project; turned off all other plugins and used the same notetag for the event that works in a blank project. For testing purposes I'm using the notetag from the helpfile:
No other events on map. I'm not using any other events on the map:

Any ideas? Kind of wish I saw this plugin before I got so far into the game. Haha.
stevenblanc

#227 Sep 9, 2020, 10:43 AM Source

Got it. I had copied and pasted the text from GitHub into a txt file and saved it as js instead of downloading it. I downloaded the js instead and its working now!

EDIT: I know I shouldn't double post so here goes; I'm assuming this is something to do with the standard resolution vs the yanfly custom resolutions:
Fortunastreet

#228 Sep 9, 2020, 10:53 AM Source

stevenblanc said:
Got it. I had copied and pasted the text from GitHub into a txt file and saved it as js instead of downloading it. I downloaded the js instead and its working now!

EDIT: I know I shouldn't double post so here goes; I'm assuming this is something to do with the standard resolution vs the yanfly custom resolutions:

View attachment 159961

There is a plugin parameter who allows you to adjust the plugin to your screen size.
If you use an higher resolution, just insert your values instead of the default ones.
stevenblanc

#229 Sep 9, 2020, 11:00 AM Source

Alexandre said:
There is a plugin parameter who allows you to adjust the plugin to your screen size.
If you use an higher resolution, just insert your values instead of the default ones.

Excellent. I guess I better dig through the helpfile before posting!
Nekohime1989

#230 Sep 10, 2020, 04:03 PM Source

Trying to add offsets to this. But it stops the from being displayed.

the note for a offset is x# and y# respectively. :shrug:
any help would be appreciated.

Interestingly enough it works fine without them but if you put in x0 and y0 it stops. (which shouldn't be happening) Am I missing something?

Fixed the first problem. the ID tag check must be last. Otherwise the x and y flags have no effect. Conditional lighting am i right. Anyways it seems to be drawing to tiled coordinates. Hmm...

Seems to be working now. Excellent. Can I contribute this somehow?
ImaginaryVillain

#231 Sep 10, 2020, 08:15 PM Source

@Nekohime1989 You can contribute either making making a GitHub account and submitting a pull request. In which case you'll get credited as a contributor there. Or you can post the script to this thread and one us will add it there. In which case GitHub won't list you as a contributor. Either way you'll get added to the plugin contributor list here, and in the plugin itself. :LZSexcite:

Aesica

#232 Sep 10, 2020, 08:24 PM Source

For the parts that parse the note tags, it's probably best to leave id for last so that it doesn't potentially gobble up one of your x or y offsets for lights where the user doesn't want an id. Here's what I mean:

Change this

Code:

                else if (x.length > 0 && this._clId === undefined) this._clId = x;
                else if (x[0] === "x" && this._clXOffset === undefined) this._clXOffset = Number(x.substr(1, x.length));
                else if (x[0] === "y" && this._clYOffset === undefined) this._clYOffset = Number(x.substr(1, x.length));

Into this

Code:

                else if (x[0] === "x" && this._clXOffset === undefined) this._clXOffset = Number(x.substr(1, x.length));
                else if (x[0] === "y" && this._clYOffset === undefined) this._clYOffset = Number(x.substr(1, x.length));
                else if (x.length > 0 && this._clId === undefined) this._clId = x;

Nekohime1989

#233 Sep 10, 2020, 10:53 PM Source

@ImaginaryVillain
Here you go then.
Aesica

#234 Sep 11, 2020, 12:13 AM Source
Oh and another thing I didn't notice right away:
Code:
Number(x); +x;
...are both the same thing. The latter is just shorter to write and easier to read.
Nekohime1989

#235 Sep 11, 2020, 12:25 AM Source

I can edit in the offsets for the mv version tomorrow btw.

edit: there's a syntax error in the version 1.27 of the mv version btw. (not sure how to fix it)
Aesica

#236 Sep 12, 2020, 07:32 PM Source

Make sure all your ()s are closed and such. That's usually where those come from.
MerlinCross

#237 Sep 13, 2020, 08:51 PM Source

Is there a way to brighten the shadowed areas outside of the light sources? So they appear closer to 'in darkness' rather than 'total darkness'?
Aesica

#238 Sep 13, 2020, 09:23 PM Source
Yeah, use the "Tint set #rrggbb" plugin command in MV (change #rrggbb to a color of your liking) or the set tint plugin command in MZ. Have these executed on a self-terminating event that autoruns on the desired map, something like this:
Code:
Plugin Command : Tint set #ff0000 Erase Event
Note that this tinting persists until you change it again on another map.
ImaginaryVillain

#239 Sep 13, 2020, 10:12 PM Source

@Nekohime1989 Glad to see you joined us on GitHub! :LZSexcite: I merged the pull request, though your name isn't showing up on the contributors list. After checking into it....
https://stackoverflow.com/questions/40644933/not-showing-as-a-contributor-on-github
...appears to have solutions. Most of which appear to be settings on your account. Let me know how things go, I'm not sure what I can do on my end but if those don't work I'll see what else I can do. :kaoswt:
Nekohime1989

#240 Sep 14, 2020, 03:53 AM Source

@ImaginaryVillain
It's fine. Just edit the first post in this topic and list me as a contributor there and we shall be good.
:)