MV - Community Lighting MV & MZ

ImaginaryVillain · 2020-07-20T18:57:26+0900

Today I propose an experiment. For awhile now I've been editing and "improving" Terrax Lighting, which was originally released under the MIT License (as is Community Lighting, so it free to use across the board)... After awhile it is now thousands of lines different than the original. So rather than confusing it with Terrax Lighting by posting it in that thread with the same name, I've forked it to Community Lighting. So why call it Community Lighting? Well that's simple, and where the experiment comes in. Everybody is invited to edit this plugin (with the hopes of improving it). If you make any changes, please post your updated version of the plugin here along with your change notes. Then we the community will test your changes and see if they're better. If they are, I'll put your version of the plugin in the first post. Oh and don't forget to add yourself to the authors if you do (though don't delete anybody). The hope here is that by getting everybody involved, we will end up with the best possible lighting plugin... Or at the very least, if that fails you'll get whatever edited version I've done for my game at the time. Contributors: Terrax, iVillain, Aesica, Eliaquim, Alexandre, Nekohime1989, Snaphat Change Notes: Spoiler: Click Here 1.0 @ImaginaryVillain Rescoped all of the variables to no longer be global. Updated for PIXI 4 & 5 Removed the outdated Terrax ABS, Quasi ABS, and Mog Time stuff references. Added compatibility for Ultra Mode 7 Fixed the issue with the Lighting plugin needing to be in a specific order in the plugin list. The plugin is now roughly 800 lines shorter and much faster, at least in my testing so far. Not going to lie, I made some other changes... But wasn't noting them because I didn't know I was making this thread at the time. 1.01 @ImaginaryVillain var rnd = -Math.floor((Math.random() * 20) + 10); $gameMap.setPEmitterZ(this._eventId, rnd); Removed the "fix" for the plugin order list due to issues with other plugins. Fixed issue with Mog Character Particles giving a "Clamp" error. 1.015 @Aesica Organized the plugin parameters into logical sections Removed the redundant "Add to options" plugin parameter. It can be ommitted from the options menu by leaving "Options Menu Entry" blank Changed the casing in a few plugin parameter names to be more consistent (minor nitpick, I know) Added the option to use modern note tag syntax " " to avoid conflicts with other plugins that may also use event/map note tags. Those note tags currently break Terrax's tagless implementation Added better default day/night colors. These can also be changed in the plugin parameters now for easier customization Added a "night switch" which, if assigned to a switch, will set to true during night or false during day (which hours count as day and night are user-defined) Expanded the "Daynight" note tag in maps so you can also set the speed if desired: "Daynight 10" for the default speed, "Daynight 0" to stop time and use the current hour's tint in one go. "Daynight" by itself uses the current speed Fixed a bug where the "Daynight" tag wouldn't tint at all if the speed was 4999. Added "Tint daylight" plugin command which is essentially "Tint set [whatever the current hour's color is]." "Tint daylight" should be used instead of the "Daynight" map note tag if you plan on applying any manual tints on the map. (Daynight blocks the use of the tint command) Changed map note tag reading to happen only once per cycle instead of X times per cycle, where X is the number of events on the map (seriously why was it done that way!?) Replaced the word salad in the help section with (what I hope is) a clearer breakdown of each command/tag and how to use it. I hope I didn't leave anything out. Added a "version" property to Community.Lighting so other plugins can ask it what version it is. 1.016 @ImaginaryVillain Removed a strange debug system that ran twice per light per frame. Removed a speed test system. Restructured the code to use a switch statement and objects instead of a huge stack of Ifs. Removed assorted commented out code from the original plugin. 1.017 @Aesica Fixed a variable scoping issue introduced by the latest optimization pass. Added explanation how to set speeds via the daynight map note tag to the help section. 1.018 @Eliaquim 1. Stored the RegExp note tag into a variable for the code does not compile the RegExp every time he uses getTag() function. 2. Replace the plugin command switch statements with an array/object lookup table. 3. Optimized some for loops changing the way they are handled from this: for (let i = 0; i < tilearray.length; i++) to this: for (let i = 0, len = tilearray.length; i < len; i++) *I did not reverse the iterator order because I don't know how the plugin works, to be sure if the order matter or not. 4. Some minor changes to if statements that are redundants like: if(args[0] == 'on' || args[0] == 'ON') to if(args[0].toLowerCase() == 'on') 1.0185 @Eliaquim…

● ARCHIVED · READ-ONLY

Started by ImaginaryVillain Jul 20, 2020, 09:57 AM 1279 posts Page 10 of 64 View original ↗

Fortunastreet

#181 Sep 2, 2020, 10:41 PM Source

It took time, but I got it.
Here is why the battle tinting bitmap wasn't updating:

Between MV and MZ there was a little change about how Bitmap is implemented:

Since the updating part of FillRect wasn't present in the MZ version, the battle tint remained the same.
I guess it may be a hint of interest for the cycle color bug.

In any case, overwriting Bitmap.FillRect seems a total overkill for just an offset.
I would want your advice about using the official making the shift manually in each call.

Also commenting all the this._setDirty of the MZ code may have other undiscovered consequences.

EDIT: I made a pull request with the fix.
Starmage

#182 Sep 4, 2020, 07:31 AM Source

Hello! I tried using the plugin for MZ, and it works wonders! <3 Thanks so much for this! :) The only problem I have is that the plugin command to activate/deactivate light from an event ID is not working. >.<

As you can see here:

I set a plugin command in a light switch event that should de-activate the light from ID 5.

And as you see here:

I have the light event its note-tag as well as the ID 5, and if that's not enough, the event ID itself is even 5... x(

Unfortunately, the light still won't deactivate despite the plugin command to disable that light from the ID. :( X(

Thanks so much for any help! :D
Fortunastreet

#183 Sep 4, 2020, 12:12 PM Source

Normally a conditional light is disable by default,
so you shouldn't see any light coming from this
event unless you use the plugin command to light it on.

That's definitively weird, I will take a look at it this evening.
Starmage

#184 Sep 4, 2020, 02:54 PM Source

Yes it is indeed weird. >.< Though tbh, I actually did not on the light via plugin command, as all I did to achieve the dark lighting was do the <CL: Daynight> note tag to have it. :o And when I do the <CL: Daynight> note tag, it immediately turns on every even on the map that has a lighting set on. So I wonder if I did something wrong in that regard as well. x( Thanks so much!

EDIT:

I tried doing this: Use the plugin command to turn a light ID on, so I can turn it off again via the same plugin command... It still didn't work and the light remained on. >.<

Or maybe I'm just stupid and there's a difference between <CL: Daynight> and <Daynight> and stuff like that I have missed? :o (but yeah, CL lights are always on by default.)
Fortunastreet

#185 Sep 4, 2020, 03:17 PM Source

I got it, while parsing the light ID, the first character of it is dropped in the code.
So "l15" becomes "15", and in your case "5" becomes an empty string,
which translates into no conditional light.

From my point of view, what is put in the notetag and what is put in the plugin command
should be the same, otherwise it is quite confusing.

@Aesica , is it what you wanted to implement or is it an error?
Starmage

#186 Sep 4, 2020, 03:31 PM Source

Ohh! So you mean I should've put "l5" instead of "5" on both the note-tags on the events and the plugin command? :o so I can also do "05" or "04" right? Since it drops the first digit.
Fortunastreet

#187 Sep 4, 2020, 03:43 PM Source

Starmage said:
Ohh! So you mean I should've put "l5" instead of "5" on both the note-tags on the events and the plugin command? :o so I can also do "05" or "04" right? Since it drops the first digit.

Only the notetag will be missing its first letter, not the plugin command.
So in your case, it will be "05" for the notetag and "5" for the command.

As I said, it is quite confusing, for me switching back to "5" and "5" would make way more sense.
As such it is likely to change soon.
Starmage

#188 Sep 4, 2020, 04:02 PM Source

Ahh alright! I tried just that, 05 on the note-tag and 5 on the plugin command, and everything works as intended! :D Thanks so much! ^_^ <3
Aesica

#189 Sep 4, 2020, 08:14 PM Source

Alexandre said:
I got it, while parsing the light ID, the first character of it is dropped in the code.
So "l15" becomes "15", and in your case "5" becomes an empty string,
which translates into no conditional light.

From my point of view, what is put in the notetag and what is put in the plugin command
should be the same, otherwise it is quite confusing.

@Aesica , is it what you wanted to implement or is it an error?

View attachment 159299
Oops, I guess I was getting a bit tired or something. The first letter should only be getting dropped if its the letter i, but it looks like I don't even have a check for the letter i in there at all. It's probably best to just drop the substr shenanigans and have it set the id exactly as is.

I was hoping to make things less confusing with the prefixes, but I guess in that case, it only made things more confusing. Oops! I'll fix that in a bit. :D

Edit: Pull request with fixes has been sent. Stand by!
MerlinCross

#190 Sep 5, 2020, 02:48 AM Source

How does one use brightness with this? I tried something like

<CL: Light 150 #A4C9E4 B25>
But it didn't work. Is it the order or do I need to go higher instead of lower?
Aesica

#191 Sep 5, 2020, 02:56 AM Source

MerlinCross said:
How does one use brightness with this? I tried something like

<CL: Light 150 #A4C9E4 B25>
But it didn't work. Is it the order or do I need to go higher instead of lower?
No you've got it right, although note that brightness is a lot more visible when applied to weaker lighting (lower #rrggbb value) than stronger lighting.
MerlinCross

#192 Sep 5, 2020, 03:00 AM Source

I'll have to do some testing then. One other thing while I'm here, trying to get the Flash Light to work on the player character. How do I set that up? On an event they interact with, just an event somewhere off to the side? I was going to search the topic but if someone can answer me faster than my own reading skills that'd be helpful(and sorry for the 2 questions in a row)
Aesica

#193 Sep 5, 2020, 03:17 AM Source

There's a plugin command to turn the player flashlight on and off. You're using MZ right?
MerlinCross

#194 Sep 5, 2020, 03:40 AM Source

Aesica said:
There's a plugin command to turn the player flashlight on and off. You're using MZ right?

MZ yes. Oh right, it's under Script command. I assume I would put the command in there then.
SirDhyne

#195 Sep 5, 2020, 07:45 AM Source

Sorry if this seems fairly obvious to the people using this/working on it, but how would one go about using this to make a room/dungeon extremely dark, then have specific light sources throughout that illuminate it? I can figure how to do the localized lighting in my head, but I don't even know where to start on having map-wide base lighting/darkness.
Aesica

#196 Sep 5, 2020, 09:16 AM Source

When I want to set the overall map brightness, I use a self-terminating parallel process event that sets the room tint (use the plugin command, not RM's built in tinting) then you just have to arrange light source events/regions/whatever you want to use wherever you want the light sources to be.
SirDhyne

#197 Sep 5, 2020, 06:25 PM Source

Using MZ, the 'Set Tint' plugin command doesn't seem to be doing anything at all. I set up a parallel process with 'Set Tint' (color 000000, fade 0 for instant result as a test) and then an 'erase event' process, nothing. I even tried setting it up in the auto-run upon entering the room as the first thing that happens, nada.

I've even set it up as an 'action button' with text popup. Text works, no change in tint. I've taken a screenshot, maybe you can see what I've done wrong here: screenshot
ScorchedGround

#198 Sep 5, 2020, 06:32 PM Source

Thats probably because you don't have any light sources in the map yet.
The lighting script is only "active" when you have a light source somewhere on the map

Try creating a new event and put
<CL: Light 0 #ffffff>
in its notebox
Aesica

#199 Sep 5, 2020, 07:41 PM Source

Just to note, even if that light source self-destructs, it still counts towards having a light source on the map. This means your autorunning, self erasing set tint event is the perfect place to put an empty light tag like the one mentioned above.
SirDhyne

#200 Sep 5, 2020, 07:43 PM Source

That did the trick, thank you. It'd be real helpful if more of this stuff was properly documented, but at least I have an idea.

All I need now is to figure out how to shut off/turn on a light source on touch event and I'll be golden. Currently, this does nothing at all except play the text. This function is very important for me as conditional lights are a must. I have the most recent version on GitHub, though it appears the pull request with fixes has yet to be approved as Aesica's fix is only a day old and GitHub for MZ is 3 days old. Hopefully it comes through soon as my problem may already be solved.

Edit: Quick question: I'm noticing now that I have an empty invis light event on the map that it's defaulting to tinting everything black (max darkness). Is this normal? Not a complaint, just curious if this is the reason everything is black without a Set Tint command.